Skip to content

Commit 105b863

Browse files
Ayase-252targos
authored andcommitted
http: explain the possibilty of refactor unused argument
PR-URL: #37275 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
1 parent 926bb4f commit 105b863

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

lib/_http_incoming.js

+4
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,10 @@ IncomingMessage.prototype.setTimeout = function setTimeout(msecs, callback) {
104104
// argument adaptor frame creation inside V8 in case that number of actual
105105
// arguments is different from expected arguments.
106106
// Ref: https://bugs.chromium.org/p/v8/issues/detail?id=10201
107+
// NOTE: Argument adapt frame issue might be solved in V8 engine v8.9.
108+
// Refactoring `n` out might be possible when V8 is upgraded to that
109+
// version.
110+
// Ref: https://v8.dev/blog/v8-release-89
107111
IncomingMessage.prototype._read = function _read(n) {
108112
if (!this._consuming) {
109113
this._readableState.readingMore = false;

0 commit comments

Comments
 (0)