Skip to content

Commit 1344bd2

Browse files
TrottRafaelGSS
authored andcommittedAug 5, 2024
test: add comments and rename test for timer robustness
The name of the test did not make it clear what it was about. (It also used "timer" in the name instead of "timers" like all the other tests.) I also added a comment to be extra clear about the test purpose and a link to the issue that was originally filed about it. PR-URL: #54008 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
1 parent da35734 commit 1344bd2

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed
 

‎test/parallel/test-timer-immediate.js renamed to ‎test/parallel/test-timers-process-tampering.js

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// Check that setImmediate works even if process is tampered with.
2+
// This is a regression test for https://github.com/nodejs/node/issues/17681.
3+
14
'use strict';
25
const common = require('../common');
36
global.process = {}; // Boom!

0 commit comments

Comments
 (0)