Skip to content

Commit 23fe596

Browse files
RafaelGSSaduh95avivkeller
authored
Apply suggestions from code review
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by: Aviv Keller <redyetidev@gmail.com>
1 parent 29ccc97 commit 23fe596

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

.github/workflows/create-release-proposal.yml

+2-7
Original file line numberDiff line numberDiff line change
@@ -51,20 +51,15 @@ jobs:
5151
- name: Install @node-core/utils
5252
run: npm install -g @node-core/utils
5353

54-
- name: Set variables
55-
run: |
56-
echo "REPOSITORY=$(echo ${{ github.repository }} | cut -d/ -f2)" >> $GITHUB_ENV
57-
echo "OWNER=${{ github.repository_owner }}" >> $GITHUB_ENV
58-
5954
- name: Configure @node-core/utils
6055
run: |
6156
ncu-config set branch "${RELEASE_BRANCH}"
6257
ncu-config set upstream origin
6358
ncu-config set username "$USERNAME"
6459
ncu-config set token "$GH_TOKEN"
6560
ncu-config set jenkins_token "$JENKINS_TOKEN"
66-
ncu-config set repo "${REPOSITORY}"
67-
ncu-config set owner "${OWNER}"
61+
ncu-config set repo "$(echo "$GITHUB_REPOSITORY" | cut -d/ -f2)"
62+
ncu-config set owner "${GITHUB_REPOSITORY_OWNER}"
6863
env:
6964
USERNAME: ${{ secrets.JENKINS_USER }}
7065
GH_TOKEN: ${{ secrets.GH_USER_TOKEN }}

tools/actions/create-release.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ git node release --prepare --skipBranchDiff
88
# We use it to not specify the branch name as it changes based on
99
# the commit list (semver-minor/semver-patch)
1010
git config push.default current
11-
echo "/## $RELEASE_DATE/,/^<a id=/{ if (!/^<a id=/) print }" > temp.awk
12-
awk -f temp.awk doc/changelogs/CHANGELOG_V23.md > pr-body.md
11+
MATCHER="/## $RELEASE_DATE/,/^<a id=/{ if (!/^<a id=/) print }"
12+
awk $MATCHER doc/changelogs/CHANGELOG_V23.md > pr-body.md
1313
gh pr create --body-file pr-body.md
1414
# TODO: ammend with proposal PR

0 commit comments

Comments
 (0)