Skip to content

Commit 27b01ed

Browse files
richardlauaduh95
authored andcommitted
test: update parallel/test-tls-dhe for OpenSSL 3.5
The output of the `s_client` command invoked by the test has changed in the OpenSSL 3.5.0 version of `s_client`. Update the test so that it works with both the old and new output -- the `s_client` binary being run may not be at the exact same version of OpenSSL as used by Node.js so the updated test allows either output. PR-URL: #57477 Refs: openssl/openssl#26734 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 52cd095 commit 27b01ed

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

test/parallel/test-tls-dhe.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,10 @@ function test(dhparam, keylen, expectedCipher) {
8585

8686
execFile(opensslCli, args, common.mustSucceed((stdout) => {
8787
assert(keylen === null ||
88-
stdout.includes(`Server Temp Key: DH, ${keylen} bits`));
88+
// s_client < OpenSSL 3.5
89+
stdout.includes(`Server Temp Key: DH, ${keylen} bits`) ||
90+
// s_client >= OpenSSL 3.5
91+
stdout.includes(`Peer Temp Key: DH, ${keylen} bits`));
8992
assert(stdout.includes(`Cipher : ${expectedCipher}`));
9093
server.close();
9194
}));

0 commit comments

Comments
 (0)