Skip to content

Commit 29fda66

Browse files
cjihrigtargos
authored andcommitted
src: simplify --debug flags
Any use of --debug, --debug=, --debug-brk, or --debug-brk= now triggers an error. That means we can eliminate their aliases with --inspect counterparts and simplify the code. PR-URL: #28615 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
1 parent d7c7023 commit 29fda66

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

src/node_options.cc

+3-5
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,9 @@ DebugOptionsParser::DebugOptionsParser() {
270270
AddAlias("--inspect=", { "--inspect-port", "--inspect" });
271271

272272
AddOption("--debug", "", &DebugOptions::deprecated_debug);
273-
AddAlias("--debug=", { "--inspect-port", "--debug" });
273+
AddAlias("--debug=", "--debug");
274+
AddOption("--debug-brk", "", &DebugOptions::deprecated_debug);
275+
AddAlias("--debug-brk=", "--debug-brk");
274276

275277
AddOption("--inspect-brk",
276278
"activate inspector on host:port and break at start of user script",
@@ -283,10 +285,6 @@ DebugOptionsParser::DebugOptionsParser() {
283285
Implies("--inspect-brk-node", "--inspect");
284286
AddAlias("--inspect-brk-node=", { "--inspect-port", "--inspect-brk-node" });
285287

286-
AddOption("--debug-brk", "", &DebugOptions::break_first_line);
287-
Implies("--debug-brk", "--debug");
288-
AddAlias("--debug-brk=", { "--inspect-port", "--debug-brk" });
289-
290288
AddOption("--inspect-publish-uid",
291289
"comma separated list of destinations for inspector uid"
292290
"(default: stderr,http)",

0 commit comments

Comments
 (0)