Skip to content

Commit 529c96d

Browse files
chasestarrMylesBorins
authored andcommitted
doc: clarify macosx-firewall suggestion BUILDING
`./tools/macosx-firewall.sh` fails if run before build step. Since the suggestion comes before the build steps in the document, this change clarifies that the script should be run after building. PR-URL: #10311 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 6b06c49 commit 529c96d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

BUILDING.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ On OS X, you will also need:
2424
this under the menu `Xcode -> Preferences -> Downloads`
2525
* This step will install `gcc` and the related toolchain containing `make`
2626

27-
* You may want to setup [firewall rules](tools/macosx-firewall.sh) to avoid
28-
popups asking to accept incoming network connections when running tests:
27+
* After building, you may want to setup [firewall rules](tools/macosx-firewall.sh)
28+
to avoid popups asking to accept incoming network connections when running tests:
2929

3030
```console
3131
$ sudo ./tools/macosx-firewall.sh

0 commit comments

Comments
 (0)