Skip to content

Commit 600dc68

Browse files
committed
fixup! fixup! fixup! src: move more crypto_dh.cc code to ncrypto
1 parent 2a8d9b4 commit 600dc68

File tree

1 file changed

+8
-16
lines changed

1 file changed

+8
-16
lines changed

src/crypto/crypto_dh.cc

+8-16
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,9 @@ void New(const FunctionCallbackInfo<Value>& args) {
8787
int32_t bits = args[0].As<Int32>()->Value();
8888
if (bits < 2) {
8989
#if OPENSSL_VERSION_MAJOR >= 3
90-
ERR_put_error(ERR_LIB_DH, 0,
91-
DH_MODULUS_TOO_SMALL, __FILE__, __LINE__);
90+
ERR_put_error(ERR_LIB_DH, 0, DH_MODULUS_TOO_SMALL, __FILE__, __LINE__);
9291
#else
93-
ERR_put_error(ERR_LIB_BN, 0,
94-
BN_R_BITS_TOO_SMALL, __FILE__, __LINE__);
92+
ERR_put_error(ERR_LIB_BN, 0, BN_R_BITS_TOO_SMALL, __FILE__, __LINE__);
9593
#endif
9694
return ThrowCryptoError(env, ERR_get_error(), "Invalid prime length");
9795
}
@@ -105,8 +103,7 @@ void New(const FunctionCallbackInfo<Value>& args) {
105103
}
106104
int32_t generator = args[1].As<Int32>()->Value();
107105
if (generator < 2) {
108-
ERR_put_error(ERR_LIB_DH, 0,
109-
DH_R_BAD_GENERATOR, __FILE__, __LINE__);
106+
ERR_put_error(ERR_LIB_DH, 0, DH_R_BAD_GENERATOR, __FILE__, __LINE__);
110107
return ThrowCryptoError(env, ERR_get_error(), "Invalid generator");
111108
}
112109

@@ -135,14 +132,12 @@ void New(const FunctionCallbackInfo<Value>& args) {
135132
if (args[1]->IsInt32()) {
136133
int32_t generator = args[1].As<Int32>()->Value();
137134
if (generator < 2) {
138-
ERR_put_error(ERR_LIB_DH, 0,
139-
DH_R_BAD_GENERATOR, __FILE__, __LINE__);
135+
ERR_put_error(ERR_LIB_DH, 0, DH_R_BAD_GENERATOR, __FILE__, __LINE__);
140136
return ThrowCryptoError(env, ERR_get_error(), "Invalid generator");
141137
}
142138
bn_g = BignumPointer::New();
143139
if (!bn_g.setWord(generator)) {
144-
ERR_put_error(ERR_LIB_DH, 0,
145-
DH_R_BAD_GENERATOR, __FILE__, __LINE__);
140+
ERR_put_error(ERR_LIB_DH, 0, DH_R_BAD_GENERATOR, __FILE__, __LINE__);
146141
return ThrowCryptoError(env, ERR_get_error(), "Invalid generator");
147142
}
148143
} else {
@@ -151,13 +146,11 @@ void New(const FunctionCallbackInfo<Value>& args) {
151146
return THROW_ERR_OUT_OF_RANGE(env, "generator is too big");
152147
bn_g = BignumPointer(reinterpret_cast<uint8_t*>(arg1.data()), arg1.size());
153148
if (!bn_g) {
154-
ERR_put_error(ERR_LIB_DH, 0,
155-
DH_R_BAD_GENERATOR, __FILE__, __LINE__);
149+
ERR_put_error(ERR_LIB_DH, 0, DH_R_BAD_GENERATOR, __FILE__, __LINE__);
156150
return ThrowCryptoError(env, ERR_get_error(), "Invalid generator");
157151
}
158152
if (bn_g.getWord() < 2) {
159-
ERR_put_error(ERR_LIB_DH, 0,
160-
DH_R_BAD_GENERATOR, __FILE__, __LINE__);
153+
ERR_put_error(ERR_LIB_DH, 0, DH_R_BAD_GENERATOR, __FILE__, __LINE__);
161154
return ThrowCryptoError(env, ERR_get_error(), "Invalid generator");
162155
}
163156
}
@@ -426,8 +419,7 @@ EVPKeyCtxPointer DhKeyGenTraits::Setup(DhKeyPairGenConfig* params) {
426419
}
427420

428421
EVPKeyCtxPointer ctx(EVP_PKEY_CTX_new(key_params.get(), nullptr));
429-
if (!ctx || EVP_PKEY_keygen_init(ctx.get()) <= 0)
430-
return {};
422+
if (!ctx || EVP_PKEY_keygen_init(ctx.get()) <= 0) return {};
431423

432424
return ctx;
433425
}

0 commit comments

Comments
 (0)