Skip to content

Commit 6614bd1

Browse files
jboarmanjoaocgreis
authored andcommitted
doc: correct vcbuild options for windows testing
Corrected parameter for running tests on Windows. Without the corrected parameters, Windows users encounter an error about failing to sign the build, "Failed to sign exe", which can be discouraging to new Windows community members. PR-URL: #10686 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
1 parent f62b879 commit 6614bd1

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

BUILDING.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ Prerequisites:
121121
To run the tests:
122122

123123
```console
124-
> .\vcbuild test
124+
> .\vcbuild nosign test
125125
```
126126

127127
To test if Node.js was built correctly:
@@ -179,7 +179,7 @@ $ ./configure --with-intl=full-icu --download=all
179179
##### Windows:
180180

181181
```console
182-
> .\vcbuild full-icu download-all
182+
> .\vcbuild nosign full-icu download-all
183183
```
184184

185185
#### Building without Intl support
@@ -196,7 +196,7 @@ $ ./configure --without-intl
196196
##### Windows:
197197

198198
```console
199-
> .\vcbuild without-intl
199+
> .\vcbuild nosign without-intl
200200
```
201201

202202
#### Use existing installed ICU (Unix / OS X only):
@@ -239,7 +239,7 @@ First unpack latest ICU to `deps/icu`
239239
as `deps/icu` (You'll have: `deps/icu/source/...`)
240240

241241
```console
242-
> .\vcbuild full-icu
242+
> .\vcbuild nosign full-icu
243243
```
244244

245245
## Building Node.js with FIPS-compliant OpenSSL

CONTRIBUTING.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -167,19 +167,19 @@ $ ./configure && make -j4 test
167167
Windows:
168168

169169
```text
170-
> vcbuild test
170+
.\vcbuild nosign test
171171
```
172172

173173
(See the [BUILDING.md](./BUILDING.md) for more details.)
174174

175175
Make sure the linter is happy and that all tests pass. Please, do not submit
176176
patches that fail either check.
177177

178-
Running `make test`/`vcbuild test` will run the linter as well unless one or
178+
Running `make test`/`.\vcbuild nosign test` will run the linter as well unless one or
179179
more tests fail.
180180

181181
If you want to run the linter without running tests, use
182-
`make lint`/`vcbuild jslint`.
182+
`make lint`/`.\vcbuild nosign jslint`.
183183

184184
If you are updating tests and just want to run a single test to check it, you
185185
can use this syntax to run it exactly as the test harness would:

0 commit comments

Comments
 (0)