Skip to content

Commit 8161287

Browse files
apapirovskiMylesBorins
authored andcommitted
test: move benchmark-dgram to sequential
This test uses hardcoded ports, it should not be located in parallel. PR-URL: #21144 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent e2a7928 commit 8161287

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

test/parallel/test-benchmark-dgram.js renamed to test/sequential/test-benchmark-dgram.js

+4
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ require('../common');
44

55
const runBenchmark = require('../common/benchmark');
66

7+
// Because the dgram benchmarks use hardcoded ports, this should be in
8+
// sequential rather than parallel to make sure it does not conflict with
9+
// tests that choose random available ports.
10+
711
runBenchmark('dgram', ['address=true',
812
'chunks=2',
913
'dur=0.1',

0 commit comments

Comments
 (0)