Skip to content

Commit 85800c4

Browse files
skomskiMylesBorins
authored andcommitted
deps: backport e28183b5 from upstream V8
Original commit message: Fix compilation with GCC 5.2 Fixes: ../../test/cctest/compiler/test-js-typed-lowering.cc:224:14: error: ‘kJSTypes’ defined but not used [-Werror=unused-variable] static Type* kJSTypes[] = {Type::Undefined(), Type::Null(), Type::Boolean(), ../../src/bignum.cc: In member function ‘void v8::internal::Bignum::AssignDecimalString(Vector<const char>)’: ../../src/bignum.cc:80:6: error: assuming signed overflow does not occur when assuming that (X + c) < X is always false [-Werror=strict-overflow] ../../src/compiler/ia32/code-generator-ia32.cc:1366:3: required from here ../../src/base/logging.h:123:26: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] DEFINE_CHECK_OP_IMPL(EQ, ==) BUG= Review URL: https://codereview.chromium.org/1371823002 Cr-Commit-Position: refs/heads/master@{#31095} PR-URL: #15562 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
1 parent a7f7a87 commit 85800c4

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

deps/v8/include/v8-version.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#define V8_MAJOR_VERSION 4
1212
#define V8_MINOR_VERSION 5
1313
#define V8_BUILD_NUMBER 103
14-
#define V8_PATCH_LEVEL 49
14+
#define V8_PATCH_LEVEL 50
1515

1616
// Use 1 for candidates and 0 otherwise.
1717
// (Boolean macro values are not supported by all preprocessors.)

deps/v8/src/bignum.cc

+3-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,9 @@ static uint64_t ReadUInt64(Vector<const char> buffer,
7070
int from,
7171
int digits_to_read) {
7272
uint64_t result = 0;
73-
for (int i = from; i < from + digits_to_read; ++i) {
73+
int to = from + digits_to_read;
74+
75+
for (int i = from; i < to; ++i) {
7476
int digit = buffer[i] - '0';
7577
DCHECK(0 <= digit && digit <= 9);
7678
result = result * 10 + digit;

deps/v8/test/cctest/compiler/test-js-typed-lowering.cc

-4
Original file line numberDiff line numberDiff line change
@@ -217,10 +217,6 @@ static Type* kNumberTypes[] = {
217217
Type::OrderedNumber(), Type::PlainNumber(), Type::Number()};
218218

219219

220-
static Type* kJSTypes[] = {Type::Undefined(), Type::Null(), Type::Boolean(),
221-
Type::Number(), Type::String(), Type::Object()};
222-
223-
224220
static Type* I32Type(bool is_signed) {
225221
return is_signed ? Type::Signed32() : Type::Unsigned32();
226222
}

0 commit comments

Comments
 (0)