Skip to content

Commit 8792609

Browse files
addaleaxtargos
authored andcommitted
test: fix flaky async-hooks/test-callback-error
Remove an unnecessary timeout. Fixes: #15985 PR-URL: #22655 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 8e4caf5 commit 8792609

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

test/async-hooks/test-callback-error.js

-12
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,6 @@ assert.ok(!arg);
5858
{
5959
console.log('start case 3');
6060
console.time('end case 3');
61-
// Timeout is set because this case is known to be problematic, so stderr is
62-
// logged for further analysis.
63-
// Ref: https://github.com/nodejs/node/issues/13527
64-
// Ref: https://github.com/nodejs/node/pull/13559
6561
const opts = {
6662
execArgv: ['--abort-on-uncaught-exception'],
6763
silent: true
@@ -78,15 +74,7 @@ assert.ok(!arg);
7874
stderr += data;
7975
});
8076

81-
const tO = setTimeout(() => {
82-
console.log(stderr);
83-
child.kill('SIGKILL');
84-
process.exit(1);
85-
}, 15 * 1000);
86-
tO.unref();
87-
8877
child.on('close', (code, signal) => {
89-
clearTimeout(tO);
9078
if (common.isWindows) {
9179
assert.strictEqual(code, 134);
9280
assert.strictEqual(signal, null);

0 commit comments

Comments
 (0)