Skip to content

Commit ad862a0

Browse files
mhdawsonrvagg
authored andcommitted
test: properly tag anonymous namespaces
For tests that use anonymous namespaces, some tagged the close of the namespace with 'namespace' while others used 'anonymous namespace'. It was suggested I should use 'anonymous namespace' in a recent PR review so make all of the tests consistent with this. PR-URL: #18583 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent c5eb1f8 commit ad862a0

File tree

7 files changed

+7
-7
lines changed

7 files changed

+7
-7
lines changed

test/addons-napi/test_make_callback_recurse/binding.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,6 @@ napi_value Init(napi_env env, napi_value exports) {
4141
return exports;
4242
}
4343

44-
} // namespace
44+
} // anonymous namespace
4545

4646
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)

test/addons/async-hooks-id/binding.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,6 @@ void Initialize(Local<Object> exports) {
3030
NODE_SET_METHOD(exports, "emitAsyncInit", EmitAsyncInit);
3131
}
3232

33-
} // namespace
33+
} // anonymous namespace
3434

3535
NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)

test/addons/async-resource/binding.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,6 @@ void Initialize(Local<Object> exports) {
109109
NODE_SET_METHOD(exports, "getResource", GetResource);
110110
}
111111

112-
} // namespace
112+
} // anonymous namespace
113113

114114
NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)

test/addons/callback-scope/binding.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,6 @@ void Initialize(v8::Local<v8::Object> exports) {
6969
NODE_SET_METHOD(exports, "testResolveAsync", TestResolveAsync);
7070
}
7171

72-
} // namespace
72+
} // anonymous namespace
7373

7474
NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)

test/addons/make-callback-recurse/binding.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,6 @@ void Initialize(Local<Object> exports) {
2626
NODE_SET_METHOD(exports, "makeCallback", MakeCallback);
2727
}
2828

29-
} // namespace
29+
} // anonymous namespace
3030

3131
NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)

test/addons/make-callback/binding.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,6 @@ void Initialize(v8::Local<v8::Object> exports) {
3434
NODE_SET_METHOD(exports, "makeCallback", MakeCallback);
3535
}
3636

37-
} // namespace
37+
} // anonymous namespace
3838

3939
NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)

test/cctest/test_inspector_socket_server.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,7 @@ static const std::string WsHandshakeRequest(const std::string& target_id) {
393393
"Sec-WebSocket-Key: aaa==\r\n"
394394
"Sec-WebSocket-Version: 13\r\n\r\n";
395395
}
396-
} // namespace
396+
} // anonymous namespace
397397

398398

399399
TEST_F(InspectorSocketServerTest, InspectorSessions) {

0 commit comments

Comments
 (0)