Skip to content

Commit adbbf0d

Browse files
Matheus Marchiniaddaleax
Matheus Marchini
authored andcommitted
test: mark test-fs-readfile-tostring-fail as flaky
test-fs-readfile-tostring-fail is failing frequently on OSX machines. There's a PR to fix this issue in libuv, but while the fix don't land on Node.js this test should be marked as flaky. Ref: #16601 Ref: libuv/libuv#1742 PR-URL: #21013 Refs: #16601 Refs: libuv/libuv#1742 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
1 parent ff5f20f commit adbbf0d

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

test/sequential/sequential.status

+3
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ test-inspector-async-hook-setup-at-signal: PASS, FLAKY
1515
[$system==linux]
1616

1717
[$system==macos]
18+
# This test will be flaky until https://github.com/libuv/libuv/pull/1742 lands
19+
# on Node.js.
20+
test-fs-readfile-tostring-fail: PASS, FLAKY
1821

1922
[$system==solaris] # Also applies to SmartOS
2023

0 commit comments

Comments
 (0)