Skip to content

Commit c71d059

Browse files
richardlauGabriel Schulhof
authored and
Gabriel Schulhof
committed
build: fix building with ninja
The ninja build places objects in a different directory. Co-authored-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #32071 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
1 parent f3643bf commit c71d059

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

node.gyp

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,11 @@
203203
'deps/acorn/dist/walk.js',
204204
],
205205
'conditions': [
206+
['GENERATOR == "ninja"', {
207+
'node_text_start_object_path': 'src/large_pages/node_text_start.node_text_start.o'
208+
}, {
209+
'node_text_start_object_path': 'node_text_start/src/large_pages/node_text_start.o'
210+
}],
206211
[ 'node_shared=="true"', {
207212
'node_target_type%': 'shared_library',
208213
'conditions': [
@@ -327,7 +332,7 @@
327332
'target_arch=="x64"', {
328333
'dependencies': [ 'node_text_start' ],
329334
'ldflags+': [
330-
'<(PRODUCT_DIR)/obj.target/node_text_start/src/large_pages/node_text_start.o'
335+
'<(obj_dir)/<(node_text_start_object_path)'
331336
]
332337
}],
333338
],

0 commit comments

Comments
 (0)