Skip to content

Commit d8961bd

Browse files
jboarmanMylesBorins
authored andcommitted
doc: correct vcbuild options for windows testing
Corrected parameter for running tests on Windows. Without the corrected parameters, Windows users encounter an error about failing to sign the build, "Failed to sign exe", which can be discouraging to new Windows community members. PR-URL: #10686 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
1 parent d3c5bc1 commit d8961bd

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

BUILDING.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ Prerequisites:
123123
To run the tests:
124124

125125
```text
126-
> .\vcbuild test
126+
> .\vcbuild nosign test
127127
```
128128

129129
To test if Node.js was built correctly:
@@ -172,7 +172,7 @@ $ ./configure --with-intl=small-icu --download=all
172172
##### Windows:
173173

174174
```text
175-
> .\vcbuild small-icu download-all
175+
> .\vcbuild nosign small-icu download-all
176176
```
177177

178178
The `small-icu` mode builds with English-only data. You can add full
@@ -195,7 +195,7 @@ $ ./configure --with-intl=full-icu --download=all
195195
##### Windows:
196196

197197
```text
198-
> .\vcbuild full-icu download-all
198+
> .\vcbuild nosign full-icu download-all
199199
```
200200

201201
#### Building without Intl support
@@ -212,7 +212,7 @@ $ ./configure --with-intl=none
212212
##### Windows:
213213

214214
```text
215-
> .\vcbuild intl-none
215+
> .\vcbuild nosign intl-none
216216
```
217217

218218
#### Use existing installed ICU (Unix / OS X only):
@@ -251,7 +251,7 @@ First unpack latest ICU to `deps/icu`
251251
as `deps/icu` (You'll have: `deps/icu/source/...`)
252252

253253
```text
254-
> .\vcbuild full-icu
254+
> .\vcbuild nosign full-icu
255255
```
256256

257257
## Building Node.js with FIPS-compliant OpenSSL

CONTRIBUTING.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -164,19 +164,19 @@ $ ./configure && make -j8 test
164164
Windows:
165165

166166
```text
167-
> vcbuild test
167+
.\vcbuild nosign test
168168
```
169169

170170
(See the [BUILDING.md](./BUILDING.md) for more details.)
171171

172172
Make sure the linter is happy and that all tests pass. Please, do not submit
173173
patches that fail either check.
174174

175-
Running `make test`/`vcbuild test` will run the linter as well unless one or
175+
Running `make test`/`.\vcbuild nosign test` will run the linter as well unless one or
176176
more tests fail.
177177

178178
If you want to run the linter without running tests, use
179-
`make lint`/`vcbuild jslint`.
179+
`make lint`/`.\vcbuild nosign jslint`.
180180

181181
If you are updating tests and just want to run a single test to check it, you
182182
can use this syntax to run it exactly as the test harness would:

0 commit comments

Comments
 (0)