Skip to content

Commit fb03faa

Browse files
Trotttargos
authored andcommitted
build: move addons message in Makefile
Displaying a message about building addons before building docs can be confusing when troubleshooting. (This just happened to me.) Move the message about building addons to just before the step for building addons. PR-URL: #23114 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
1 parent 48c1c42 commit fb03faa

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -278,9 +278,9 @@ jstest: build-addons build-addons-napi ## Runs addon tests and JS tests
278278
.PHONY: test
279279
# This does not run tests of third-party libraries inside deps.
280280
test: all ## Runs default tests, linters, and builds docs.
281+
$(MAKE) -s test-doc
281282
@echo "Build the addons before running the tests so the test results"
282283
@echo "can be displayed together"
283-
$(MAKE) -s test-doc
284284
$(MAKE) -s build-addons
285285
$(MAKE) -s build-addons-napi
286286
$(MAKE) -s cctest

0 commit comments

Comments
 (0)