fixup

Author: shigeki

test/fixtures/0-dns/README.md

@@ -22,5 +22,5 @@ $ npm install
 
 $ node ./createCert.js
 $ openssl x509 -text -in 0-dns-cert.pem
-(You can not see evel.example.com in subjectAltName field)
+(You can not see evil.example.com in subjectAltName field)
 ```

test/fixtures/0-dns/createCert.js renamed to test/fixtures/0-dns/create-cert.js

@@ -1,8 +1,8 @@
 'use strict';
-const fs = require('fs');
+const asn1 = require('asn1.js');
 const crypto = require('crypto');
+const fs = require('fs');
 const rfc5280 = require('asn1.js-rfc5280');
-const asn1 = require('asn1.js');
 const BN = asn1.bignum;
 
 const id_at_commonName = [ 2, 5, 4, 3 ];
@@ -12,7 +12,7 @@ const sigalg = 'RSA-SHA256';
 
 const private_key = fs.readFileSync('./0-dns-key.pem');
 // public key file can be generated from the private key with
-// openssl rsa -in 0-dns-key.pem -RSAPublicKey_out -outform der \
+// openssl rsa -in 0-dns-key.pem -RSAPublicKey_out -outform der
 // -out 0-dns-rsapub.der
 const public_key = fs.readFileSync('./0-dns-rsapub.der');
 
@@ -30,32 +30,32 @@ const PrintStr = asn1.define('PrintStr', function() {
 const issuer = PrintStr.encode('ca.example.com', 'der');
 const subject = PrintStr.encode('evil.example.com', 'der');
 
-const tbs =
-  { version: 'v3',
-    serialNumber: new BN('01', 16),
-    signature: { algorithm: sha256WithRSAEncryption, parameters: null_},
-    issuer: { type: 'rdnSequence',
-              value: [ [{type: id_at_commonName, value: issuer}] ] },
-    validity:
-    { notBefore: { type: 'utcTime', value: now },
-      notAfter: { type: 'utcTime', value: now + days * 86400000} },
-    subject: { type: 'rdnSequence',
-               value: [ [{type: id_at_commonName, value: subject}] ] },
-    subjectPublicKeyInfo:
-    { algorithm: { algorithm: rsaEncryption, parameters: null_},
-      subjectPublicKey: { unused: 0, data: public_key} },
-    extensions:
-    [ { extnID: 'subjectAlternativeName',
-        critical: false,
-        // subjectAltName which contains '\0' character to check CVE-2009-2408
-        extnValue: [
-          { type: 'dNSName', value: 'good.example.org\u0000.evil.example.com' },
-          { type: 'dNSName', value: 'just-another.example.com' },
-          { type: 'iPAddress', value: Buffer.from('08080808', 'hex') },
-          { type: 'iPAddress', value: Buffer.from('08080404', 'hex') },
-          { type: 'dNSName', value: 'last.example.com' } ] }
-    ]
-  };
+const tbs = {
+  version: 'v3',
+  serialNumber: new BN('01', 16),
+  signature: { algorithm: sha256WithRSAEncryption, parameters: null_},
+  issuer: { type: 'rdnSequence',
+            value: [ [{type: id_at_commonName, value: issuer}] ] },
+  validity:
+  { notBefore: { type: 'utcTime', value: now },
+    notAfter: { type: 'utcTime', value: now + days * 86400000} },
+  subject: { type: 'rdnSequence',
+             value: [ [{type: id_at_commonName, value: subject}] ] },
+  subjectPublicKeyInfo:
+  { algorithm: { algorithm: rsaEncryption, parameters: null_},
+    subjectPublicKey: { unused: 0, data: public_key} },
+  extensions:
+  [ { extnID: 'subjectAlternativeName',
+      critical: false,
+      // subjectAltName which contains '\0' character to check CVE-2009-2408
+      extnValue: [
+        { type: 'dNSName', value: 'good.example.org\u0000.evil.example.com' },
+        { type: 'dNSName', value: 'just-another.example.com' },
+        { type: 'iPAddress', value: Buffer.from('08080808', 'hex') },
+        { type: 'iPAddress', value: Buffer.from('08080404', 'hex') },
+        { type: 'dNSName', value: 'last.example.com' } ] }
+  ]
+};
 
 const tbs_der = rfc5280.TBSCertificate.encode(tbs, 'der');
 
@@ -65,10 +65,10 @@ const signature = sign.sign(private_key);
 
 const cert = {
   tbsCertificate: tbs,
-  signatureAlgorithm: { algorithm: sha256WithRSAEncryption, parameters: null_},
+  signatureAlgorithm: { algorithm: sha256WithRSAEncryption, parameters: null_ },
   signature:
   { unused: 0,
-    data: signature}
+    data: signature }
 };
 const pem = rfc5280.Certificate.encode(cert, 'pem', {label: 'CERTIFICATE'});
 

test/parallel/test-tls-0-dns-altname.js

@@ -2,7 +2,7 @@
 const common = require('../common');
 const assert = require('assert');
 
-// check getPeerCertificate can properly handle '\0' for fix CVE-2009-2408
+// Check getPeerCertificate can properly handle '\0' for fix CVE-2009-2408.
 
 if (!common.hasCrypto) {
   common.skip('missing crypto');