tools: fix nits in tools/doc/common.js

vsemozhetbyt · MylesBorins · commit fe4e511ae8ed · 2018-08-17T15:50:07.000-04:00
PR-URL: #19599 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/tools/doc/common.js b/tools/doc/common.js
@@ -3,11 +3,9 @@
 const yaml = require('js-yaml');
 
 function isYAMLBlock(text) {
-  return !!text.match(/^<!-- YAML/);
+  return /^<!-- YAML/.test(text);
 }
 
-exports.isYAMLBlock = isYAMLBlock;
-
 function arrify(value) {
   return Array.isArray(value) ? value : [value];
 }
@@ -32,11 +30,8 @@ function extractAndParseYAML(text) {
   }
 
   meta.changes = meta.changes || [];
-  for (const entry of meta.changes) {
-    entry.description = entry.description.replace(/^\^\s*/, '');
-  }
 
   return meta;
 }
 
-exports.extractAndParseYAML = extractAndParseYAML;
+module.exports = { isYAMLBlock, extractAndParseYAML };

Original file line number	Diff line number	Diff line change
`@@ -3,11 +3,9 @@`
`3`	`3`	`const yaml = require('js-yaml');`
`4`	`4`
`5`	`5`	`function isYAMLBlock(text) {`
`6`		`- return !!text.match(/^<!-- YAML/);`
	`6`	`+ return /^<!-- YAML/.test(text);`
`7`	`7`	`}`
`8`	`8`
`9`		`-exports.isYAMLBlock = isYAMLBlock;`
`10`		`-`
`11`	`9`	`function arrify(value) {`
`12`	`10`	`return Array.isArray(value) ? value : [value];`
`13`	`11`	`}`
`@@ -32,11 +30,8 @@ function extractAndParseYAML(text) {`
`32`	`30`	`}`
`33`	`31`
`34`	`32`	`meta.changes = meta.changes \|\| [];`
`35`		`- for (const entry of meta.changes) {`
`36`		`- entry.description = entry.description.replace(/^\^\s*/, '');`
`37`		`- }`
`38`	`33`
`39`	`34`	`return meta;`
`40`	`35`	`}`
`41`	`36`
`42`		`-exports.extractAndParseYAML = extractAndParseYAML;`
	`37`	`+module.exports = { isYAMLBlock, extractAndParseYAML };`