-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
https: certificate validation fails when using servername option #1106
Labels
Comments
I provide a PR incl. test for |
/cc @indutny - seems like an unambiguous bug to me.. |
Surely a bug, @skenqbx please go ahead ;) Please submit a test first, though. Just to make sure that we are on the same page. |
This was referenced Mar 9, 2015
This was referenced Dec 20, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Agent#createSocket()
overwritesoptions.servername
leading to atls.checkServerIdentity()
against hostname instead of servername.I usually disabled connection pooling in that case, but that is not possible anymore as
ClientRequest#constructor
always sets an agent.Not sure if this is intentional; Did I overlook something in the changelog?
The text was updated successfully, but these errors were encountered: