http2 - http/1 compat errors

[ronag]

Consider the following:

const server = http2.createServer({
  allowHTTP1: true
})

server.on('stream', stream => {
  stream.on('error', err => console.error(err))
})

server.on('request', req => {
  if (req.httpVersionMajor >= 2) {
    // XXX workaround
    // req.on('error', () => { /* Do nothing ... */ })
    // res.on('error', () => { /* Do nothing ... */ })
    // NOTE http2 request are handled through HTTP2Server's 'stream' handler.
    return
  }
})

If stream now emit an error we will get an unhandled exception even though we have stream.on('error', ...) because we didn't add an error listener to the compat request which will throw like this:

function onStreamError(error) {
  const request = this[kRequest];
  request.emit('error', error);
}

Causing a crash like this:

"type": "NodeError",
      "message": "Stream closed with error code 8",
      "stack": "Error [ERR_HTTP2_STREAM_ERROR]: Stream closed with error code 8\n    at process.nextTick (internal/http2/core.js:1530:21)\n    at _combinedTickCallback (internal/process/next_tick.js:131:7)\n    at process._tickCallback (internal/process/next_tick.js:180:9)"

[apapirovski]

Thanks for the report @ronag. Are you using 8.4 or a build from master? This was patched recently to no longer forward the errors to request and response.

In general, you might find it a more pleasant experience working with a build from master which has a lot of bug fixes for http2. Let me know if you need any help or have any questions for that.

[ronag]

I'm running 8.4.

Yea, I'm using nvm for handling my mode versions. I wish they had a build from master option. I'll see if I can go over to just building it manually.

[dougwilson]

If nvm had just a nightly option, that would be prefect. Here is the issue for nvm to add nightly support: nvm-sh/nvm#1053