http2: when is socket._paused set to true?

[trivikr]

As part of improving code coverage for http2 in #14985, I wrote some unit tests for socket operations in #16211

I noticed that:

• socketOnResume returns this.pause() if this._paused is true

  node/lib/internal/http2/core.js

  Lines 2180 to 2181 in 411695e

  	if (this._paused)
  	return this.pause();

• if this._paused is true, it's set to false in socketOnDrain

  node/lib/internal/http2/core.js

  Line 2198 in 411695e

  this._paused = false;

However, I didn't find any code which sets socket._paused to true https://github.com/nodejs/node/search?utf8=%E2%9C%93&q=_paused&type=
Is this a bug? Or is there a way to mock value of socket._paused while testing?

[apapirovski]

cc @jasnell — this seems like an incomplete implementation or a bug, any insight into what the original thinking was?

[trivikr]

For reference, initial commit which introduced _paused: nodejs/http2@4e47406

[trivikr]

This issue is likely to be irrelevant if socket operations are removed in #16252

[Fishrock123]

Isn't this part of the streams implementation?

[apapirovski]

@Fishrock123 as far as I can tell it's custom to _http_server.js

[trivikr]

The socketOn* methods are being removed in #16330
This issue will cease to exist when the PR is merged.

[apapirovski]

We still have unused stream._paused but this issue isn't addressing that so I'm closing since the PR removing this just landed.