Skip to content

Nominating @psmarshall as a Collaborator #23849

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Trott opened this issue Oct 24, 2018 · 17 comments
Closed

Nominating @psmarshall as a Collaborator #23849

Trott opened this issue Oct 24, 2018 · 17 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@Trott
Copy link
Member

Trott commented Oct 24, 2018 •
edited
Loading

I'd like to nominate @psmarshall as a Collaborator. They are on the V8 team at Google and do a lot with benchmarks. They have eight commits on master but also a number of backports of V8 fixes and ABI compatibility patches for LTS versions so that V8 can be updated there.

Commits: https://github.com/nodejs/node/commits?author=psmarshall
Comments: https://github.com/nodejs/node/search?q=commenter%3Apsmarshall&type=Issues

Especially for the backports, being able to kick off the V8 CI jobs will be helpful for them.

@nodejs/collaborators
@Trott Trott changed the title Nominating Peter Marshall as a Collaborator Nominating @psmarshall as a Collaborator Oct 24, 2018
@gireeshpunathil
Copy link
Member

+1

1 similar comment
@bmeurer
Copy link
Member

bmeurer commented Oct 24, 2018

+1

@addaleax addaleax added the meta Issues and PRs related to the general management of the project. label Oct 24, 2018
@vdeturckheim
Copy link
Member

👍

4 similar comments
@hashseed
Copy link
Member

+1

@mhdawson
Copy link
Member

+1

@trivikr
Copy link
Member

trivikr commented Oct 24, 2018

+1

@apapirovski
Copy link
Contributor

+1

@Fishrock123
Copy link
Contributor

+1 (I forgot to do this after the collab summit... sorry 😞)

@cjihrig
Copy link
Contributor

cjihrig commented Oct 24, 2018

+1

2 similar comments
@cfanoulis
Copy link
Contributor

+1

@BridgeAR
Copy link
Member

+1

@addaleax addaleax mentioned this issue Oct 29, 2018
Closed
@fhinkel
Copy link
Member

fhinkel commented Oct 30, 2018

+1

@mcollina
Copy link
Member

@psmarshall I'm available to onboard you at NCEU.

@psmarshall
Copy link
Contributor

@mcollina OK sounds good, thanks

@mhdawson
Copy link
Member

+1

@joyeecheung
Copy link
Member

This has been open for a week so according to the GOVERNANCE.md the nomination has now been considered accepted. Marking it as tsc-agenda so that it gets announced at the TSC meeting.

@joyeecheung joyeecheung added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Oct 31, 2018
@mhdawson mhdawson mentioned this issue Nov 5, 2018
Closed
@Trott Trott removed the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Nov 5, 2018
@Trott
Copy link
Member Author

Trott commented Nov 7, 2018

This appears to be done! (Thanks to whoever handled the onboarding.)

@Trott Trott closed this as completed Nov 7, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests