intl: Will Intl.Segmenter need full ICU in Node.js even for the 'en' locale?

[vsemozhetbyt]

See tc39/proposal-intl-segmenter#50

[vsemozhetbyt]

cc @nodejs/v8 @nodejs/intl.

[devsnek]

I'm a fan of anything that forces us to ship full icu

[vsemozhetbyt]

The answer from the implementers:

Question: Will this need full ICU in Node.js even for the 'en' locale?
Answer: YES

Well, this is a strong argument to ship full ICU by default.

[vsemozhetbyt]

Our table is not correct anymore: small-icu for Intl is not even partial (English-only) now.

[jasnell]

/cc @srl295

[refack]

Well, this is a strong argument to ship full ICU by default.

As I mentioned in #21676, we should separate dev & test builds from release builds.
Turning on full-icu only for release builds has IMO the most benefit, while carries the least cost for the current dev & test workflow (and build infra overhead).
We could add some full-icu specific tests that will run only as part of the daily CI job.

/CC @nodejs/testing

[vsemozhetbyt]

For this particular issue, see this and this comment:

If they cut out necessary icu data for such configuration there are no way v8 code can load the icu data they cut out. that should be a node.js bug instead. - They cut out too much!

[Trott]

Is there anything to do at this time other than be aware that This Is Coming?

[Trott]

Should this be closed for the time being? If not, what is the condition for closing?

[vsemozhetbyt]

what is the condition for closing?

Maybe clarification if this is wontfix from the ICU team?

[Trott]

@nodejs/intl Are we going to start shipping full icu? Or not? Or to be determined?

[srl295]

So,for this case, I'd think we would just change the definition of 'small icu' to include the break iterator files.

It's this line, to change brkiter from none to proabbly locales (meaning just 'en' by default) https://github.com/nodejs/node/blob/master/tools/icu/icu_small.json#L19

So probably this issue should be closed with "no", or used to put the needed fix in once this v8 change lands.

[richardlau]

We're shipping full icu by default now so closing.