Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Latest Node.js crashes when ran with --interpreted-frames-native-stack #27346

Closed
mmarchini opened this issue Apr 22, 2019 · 1 comment
Closed
Labels
confirmed-bug Issues with confirmed bugs. v8 engine Issues and PRs related to the V8 dependency.

Comments

@mmarchini
Copy link
Contributor

  • Version: master / v12.0.0
  • Platform: any
  • Subsystem: V8

This is an upstream bug and there's already an issue in the V8 tracker as well as a PR to fix it, but since we're about to release v12.0.0 and the issue will be present there, I think it's a good idea to have this registered here in case users stumble upon that.


The --interpreted-frames-native-stack flag - which is used to allow system profilers to understand V8 interpreted frames - is not compatible with code cache, which we introduced a while back in #24950. If we try to run Node.js with this flag - regardless of the script being executed -, Node.js will crash:

$ ./node --interpreted-frames-native-stack
#
# Fatal error in , line 0
# Check failed: !obj->IsCode().
#
#
#
#FailureMessage Object: 0x7ffc8458e3a0[1]    16377 illegal hardware instruction (core dumped)  ./node --interpreted-frames-native-stack

We need to backport https://chromium-review.googlesource.com/c/v8/v8/+/1570582 once it lands upstream, as well as re-enable the Linux perf tests on our V8 CI machines (nodejs/build#1774) once the flag is fixed.

@mmarchini
Copy link
Contributor Author

Fixed in #27615 and available on v12.3.0.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
confirmed-bug Issues with confirmed bugs. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

No branches or pull requests

1 participant