Keeping up with landing things and reviews

[benjamingr]

Hey,

A lot of changes regarding how to land things happened since I joined Node. With the commit queue, NCU, criteria changes, team pings and other things. Some collaborators (like Ruben) helped me in the past when I wanted to keep up, it was always 1x1.

I have a feeling (not sure if it's well founded) that the number of people reviewing things is rather small and the number of people landing things is significantly smaller.

I think it would be useful for the TSC or just a collaborator that feels like it to do a session (similar to the original collaborator onboarding) that surveys the (updated) protocols for collaborators namely:

• Landing things technical know how ("you don't need to apply a patch anymore, just add this label - if that doesn't work here is node core utils etc").
• Automation (what changed, GitHub actions linting etc).
• Reviewing things, teams team pings and how to better help with reviews.
• Behaviour in the repo (responding to non-collaborators in PRs, expected conduct, how to best ask for moderation).

If something like this is already happening - feel free to point me there.

---

As a collaborator, I often have periods (of a month or a few at a time) of zero to no activity and then bursts of activity. I am not as engaged as most of the TSC (I'm hoping that's the case :]) so it's a lot harder to keep up.

This is just something I came up with when I noticed a long-time useful contributor stumble with this and had a "If it's happening to them and it's happening to me, it's probably happening to others".

^{Of course, I would totally understand if no one picks it up - I am asking for "free work" - it's just something I think would be useful}

[benjamingr]

I'll ping @nodejs/tsc in case the TSC wants to pick this up.

(I'm not pinging nodejs/collaborators since that feels like a much too broad ping - but I'm not sure that's a correct call since I think feedback from other collaborators would be very useful)

[mcollina]

+1 I think this would be great to do. Maybe @mmarchini? She worked on most of the new automation.

[Trott]

Some stats for the last 6 months that are probably more interesting than useful:

1712 commits landed

Of the 104 accounts (including the bot) in the Collaborators group, 56 landed at least 1 commit in that time

full data table

commits	landed by	percentage
363	Rich Trott	21.20%
297	James M Snell	17.35%
215	Anna Henningsen	12.56%
107	Michaël Zasso	6.25%
91	Node.js GitHub Bot	5.32%
78	Ruben Bridgewater	4.56%
45	Daniel Bevenius	2.63%
44	Robert Nagy	2.57%
36	Colin Ihrig	2.10%
35	Myles Borins	2.04%
31	Mary Marchini	1.81%
30	gengjiawen	1.75%
24	Richard Lau	1.40%
23	Gireesh Punathil	1.34%
21	Guy Bedford	1.23%
21	Shelley Vohr	1.23%
19	Joyee Cheung	1.11%
16	Antoine du Hamel	0.93%
15	Michael Dawson	0.88%
14	Gabriel Schulhof	0.82%
14	Luigi Pinca	0.82%
13	Matteo Collina	0.76%
10	Gerhard Stoebich	0.58%
10	Andrey Pechkurov	0.58%
10	Daijiro Wachi	0.58%
10	Gus Caplan	0.58%
9	rickyes	0.53%
9	Benjamin Coe	0.53%
9	Beth Griggs	0.53%
9	himself65	0.53%
8	Derek Lewis	0.47%
8	Tobias Nießen	0.47%
7	Bradley Meck	0.41%
7	Ujjwal Sharma	0.41%
6	Juan José Arboleda	0.35%
5	Bartosz Sosnowski	0.29%
5	Alba Mendez	0.29%
5	Geoffrey Booth	0.29%
5	Sam Roberts	0.29%
4	Evan Lucas	0.23%
3	João Reis	0.18%
3	Brian White	0.18%
2	Danielle Adams	0.12%
2	Ruy Adorno	0.12%
2	Denys Otrishko	0.12%
2	Stewart X Addison	0.12%
1	Adrian Estrada	0.06%
1	Ash Cripps	0.06%
1	Steven R. Loomis	0.06%
1	Jan Krems	0.06%
1	Harshitha K P	0.06%
1	Yongsheng Zhang	0.06%
1	Leko	0.06%
1	Pranshu Srivastava	0.06%
1	David Carlier	0.06%
1	legendecas	0.06%

[Trott]

Of the 104 accounts (including the bot) in the Collaborators group, 56 landed at least 1 commit in that time

I would love to see that "56" be a bigger number, so I'm 👍 on doing this if it will help.

[benjamingr]

@Trott those numbers show that more than half of all node commits landed in the last 6 months are you, @addaleax and @jasnell :]

Given we squash commits (usually) that difference is even larger.

[Trott]

I guess we wouldn't even need to to create new material for this. We could just walk through the relevant parts of the onboarding.md doc.

[mhdawson]

A session sounds great to encourage/make people more comfortable landing.

[lucky-gru]

I guess we wouldn't even need to do create new material for this. We could just walk through the relevant parts of the onboarding.md doc.

that's awesome

[mmarchini]

A session sounds like a good idea. Do you think a blog post would also be helpful?

[benjamingr]

@mmalecki sure, though the content I am referring to is specifically for collaborators - so the reach of such a blog post would be ±100 people and it would probably confuse the rest of the Node.js blog readers if that's where it'll be published.

[mmarchini]

Would it make sense for us to have a collaborators blog? 😄

[joyeecheung]

Would it make sense for us to have a collaborators blog? 😄

We could just start a new repo and use GitHub pages anyway :)

[mmarchini]

Ohh that's a good idea :D

[benjamingr]

This has stalled a while ago - so closing (with the usual "if anyone feels differently feel free to reopen").