Skip to content

Incosistant result between test and it in node:test #48582

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
himself65 opened this issue Jun 28, 2023 · 5 comments
Closed

Incosistant result between test and it in node:test #48582

himself65 opened this issue Jun 28, 2023 · 5 comments
Labels
test_runner Issues and PRs related to the test runner subsystem. test Issues and PRs related to the tests.

Comments

@himself65
Copy link
Member

himself65 commented Jun 28, 2023

Version

v18.15.0

Platform

Darwin Himself65-Air 22.5.0 Darwin Kernel Version 22.5.0: Mon Apr 24 20:52:43 PDT 2023; root:xnu-8796.121.2~5/RELEASE_ARM64_T8112 arm64

Subsystem

test

What steps will reproduce the bug?

I will add a minimum repo to reproduce the bug later, but for now you have to clone and run it manually

https://github.com/toeverything/AFFiNE/tree/master/apps/server

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior? Why is that the expected behavior?

No response

What do you see instead?

Feishu20230628-161112.mp4

Additional information

No response

@himself65 himself65 added the test Issues and PRs related to the tests. label Jun 28, 2023
@aduh95
Copy link
Contributor

aduh95 commented Jun 28, 2023

Can you share code and copy/paste output rather than a video? Videos take more bandwidth and are not very helpful for folks with visual disabilities.

@atlowChemi
Copy link
Member

I believe this has been fixed on newer Node versions: #46889

@atlowChemi atlowChemi added the test_runner Issues and PRs related to the test runner subsystem. label Jun 28, 2023
@cjihrig
Copy link
Contributor

cjihrig commented Jun 29, 2023

I agree it looks like it should be fixed. It looks like that change was backported in the 18.16.0 release, but this bug report is for 18.16.0.

EDIT: Looking at the backport commit I see that the added doc metadata says 18.6.0 instead of 18.16.0, so it's possible something went wrong.

@himself65
Copy link
Member Author

Can you share code and copy/paste output rather than a video? Videos take more bandwidth and are not very helpful for folks with visual disabilities.

This is copy video from my colleague, and I confirm that he's node.js 18.15.0. And I double-checked that it works well in 18.16.0.

And the way to reproduce it is to replace it with test (code https://github.com/toeverything/AFFiNE/blob/2c95bfcc3dfe0dfbeee39254f80a6f4760fb67b8/apps/server/src/tests/workspace.spec.ts#L2)

Since I also believe it has been fixed. I won't give the minimum reproduction code.

@himself65
Copy link
Member Author

I agree it looks like it should be fixed. It looks like that change was backported in the 18.16.0 release, but this bug report is for 18.16.0.

EDIT: Looking at the backport commit I see that the added doc metadata says 18.6.0 instead of 18.16.0, so it's possible something went wrong.

I think it's correct. because it did land in 18.6.0 first (#43420). My issue typed wrong version

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
test_runner Issues and PRs related to the test runner subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

4 participants