12.16.2 12.16.1 12.16.0
diff --git a/GOVERNANCE.md b/GOVERNANCE.md
index b54f2e81b14d54..aeb1d9c65e1f11 100644
--- a/GOVERNANCE.md
+++ b/GOVERNANCE.md
@@ -2,16 +2,30 @@
+* [Triagers](#triagers)
* [Collaborators](#collaborators)
- * [Collaborator Activities](#collaborator-activities)
-* [Technical Steering Committee](#technical-steering-committee)
- * [TSC Meetings](#tsc-meetings)
-* [Collaborator Nominations](#collaborator-nominations)
+ * [Collaborator activities](#collaborator-activities)
+* [Technical steering committee](#technical-steering-committee)
+ * [TSC meetings](#tsc-meetings)
+* [Collaborator nominations](#collaborator-nominations)
* [Onboarding](#onboarding)
-* [Consensus Seeking Process](#consensus-seeking-process)
+* [Consensus seeking process](#consensus-seeking-process)
+## Triagers
+
+Triagers assess newly-opened issues in the nodejs/node and nodejs/help
+repositories. There is no GitHub team for triagers at the moment.
+
+Triagers have:
+* ability to label issues
+* ability to comment, close, and reopen issues
+
+See:
+
+* [A guide for triagers](./doc/guides/contributing/issues.md#triaging-a-bug-report)
+
## Collaborators
Node.js Core Collaborators maintain the [nodejs/node][] GitHub repository.
@@ -41,7 +55,7 @@ See:
* [List of Collaborators](./README.md#current-project-team-members)
* [A guide for Collaborators](./doc/guides/collaborator-guide.md)
-### Collaborator Activities
+### Collaborator activities
* Helping users and novice contributors
* Contributing code and documentation changes that improve the project
@@ -70,7 +84,7 @@ The current list of TSC members is in
The [TSC Charter][] governs the operations of the TSC. All changes to the
Charter need approval by the OpenJS Foundation Board of Directors.
-### TSC Meetings
+### TSC meetings
The TSC meets in a voice conference call. Each year, the TSC elects a chair to
run the meetings. The TSC streams its meetings for public viewing on YouTube or
@@ -104,7 +118,7 @@ the issue tracker is:
and no TSC opposition.
* If there is an extended impasse, a TSC member may make a motion for a vote.
-## Collaborator Nominations
+## Collaborator nominations
Existing Collaborators can nominate someone to become a Collaborator. Nominees
should have significant and valuable contributions across the Node.js
@@ -151,7 +165,7 @@ After the nomination passes, a TSC member onboards the new Collaborator. See
[the onboarding guide](./onboarding.md) for details of the onboarding
process.
-## Consensus Seeking Process
+## Consensus seeking process
The TSC follows a [Consensus Seeking][] decision-making model per the
[TSC Charter][].
diff --git a/Makefile b/Makefile
index 4391499052a449..6b3818b01d5dee 100644
--- a/Makefile
+++ b/Makefile
@@ -298,8 +298,8 @@ v8:
jstest: build-addons build-js-native-api-tests build-node-api-tests ## Runs addon tests and JS tests
$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) \
--skip-tests=$(CI_SKIP_TESTS) \
- $(CI_JS_SUITES) \
- $(CI_NATIVE_SUITES)
+ $(JS_SUITES) \
+ $(NATIVE_SUITES)
.PHONY: tooltest
tooltest:
@@ -492,9 +492,11 @@ test-all-valgrind: test-build
test-all-suites: | clear-stalled test-build bench-addons-build doc-only ## Run all test suites.
$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) test/*
+JS_SUITES ?= default
+NATIVE_SUITES ?= addons js-native-api node-api
# CI_* variables should be kept synchronized with the ones in vcbuild.bat
-CI_NATIVE_SUITES ?= addons js-native-api node-api
-CI_JS_SUITES ?= default
+CI_NATIVE_SUITES ?= $(NATIVE_SUITES) benchmark
+CI_JS_SUITES ?= $(JS_SUITES)
ifeq ($(node_use_openssl), false)
CI_DOC := doctool
else
@@ -505,7 +507,7 @@ endif
# Build and test addons without building anything else
# Related CI job: node-test-commit-arm-fanned
test-ci-native: LOGLEVEL := info
-test-ci-native: | test/addons/.buildstamp test/js-native-api/.buildstamp test/node-api/.buildstamp
+test-ci-native: | benchmark/napi/.buildstamp test/addons/.buildstamp test/js-native-api/.buildstamp test/node-api/.buildstamp
$(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \
--mode=$(BUILDTYPE_LOWER) --flaky-tests=$(FLAKY_TESTS) \
$(TEST_CI_ARGS) $(CI_NATIVE_SUITES)
@@ -527,7 +529,7 @@ test-ci-js: | clear-stalled
.PHONY: test-ci
# Related CI jobs: most CI tests, excluding node-test-commit-arm-fanned
test-ci: LOGLEVEL := info
-test-ci: | clear-stalled build-addons build-js-native-api-tests build-node-api-tests doc-only
+test-ci: | clear-stalled bench-addons-build build-addons build-js-native-api-tests build-node-api-tests doc-only
out/Release/cctest --gtest_output=xml:out/junit/cctest.xml
$(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \
--mode=$(BUILDTYPE_LOWER) --flaky-tests=$(FLAKY_TESTS) \
@@ -654,8 +656,8 @@ test-with-async-hooks:
$(MAKE) build-node-api-tests
$(MAKE) cctest
NODE_TEST_WITH_ASYNC_HOOKS=1 $(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) \
- $(CI_JS_SUITES) \
- $(CI_NATIVE_SUITES)
+ $(JS_SUITES) \
+ $(NATIVE_SUITES)
.PHONY: test-v8
@@ -1034,7 +1036,7 @@ pkg-upload: pkg
scp -p $(TARNAME).pkg $(STAGINGSERVER):nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).pkg
ssh $(STAGINGSERVER) "touch nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).pkg.done"
-$(TARBALL): release-only $(NODE_EXE) doc
+$(TARBALL): release-only doc-only
git checkout-index -a -f --prefix=$(TARNAME)/
mkdir -p $(TARNAME)/doc/api
cp doc/node.1 $(TARNAME)/doc/node.1
diff --git a/README.md b/README.md
index 85211650f71096..84ab9cd5862138 100644
--- a/README.md
+++ b/README.md
@@ -247,6 +247,8 @@ For information about the governance of the Node.js project, see
**Anto Aravinth** <anto.aravinth.cse@gmail.com> (he/him)
* [apapirovski](https://github.com/apapirovski) -
**Anatoli Papirovski** <apapirovski@mac.com> (he/him)
+* [AshCripps](https://github.com/AshCripps) -
+**Ash Cripps** <ashley.cripps@ibm.com>
* [bcoe](https://github.com/bcoe) -
**Ben Coe** <bencoe@gmail.com> (he/him)
* [bengl](https://github.com/bengl) -
@@ -311,6 +313,8 @@ For information about the governance of the Node.js project, see
**Gireesh Punathil** <gpunathi@in.ibm.com> (he/him)
* [guybedford](https://github.com/guybedford) -
**Guy Bedford** <guybedford@gmail.com> (he/him)
+* [HarshithaKP](https://github.com/HarshithaKP) -
+**Harshitha K P** <harshitha014@gmail.com> (she/her)
* [hashseed](https://github.com/hashseed) -
**Yang Guo** <yangguo@chromium.org> (he/him)
* [himself65](https://github.com/himself65) -
@@ -373,6 +377,8 @@ For information about the governance of the Node.js project, see
**Stephen Belanger** <admin@stephenbelanger.com> (he/him)
* [refack](https://github.com/refack) -
**Refael Ackermann (רפאל פלחי)** <refack@gmail.com> (he/him/הוא/אתה)
+* [rexagod](https://github.com/rexagod) -
+**Pranshu Srivastava** <rexagod@gmail.com> (he/him)
* [richardlau](https://github.com/richardlau) -
**Richard Lau** <riclau@uk.ibm.com>
* [ronag](https://github.com/ronag) -
@@ -407,8 +413,6 @@ For information about the governance of the Node.js project, see
**Stewart X Addison** <sxa@uk.ibm.com>
* [targos](https://github.com/targos) -
**Michaël Zasso** <targos@protonmail.com> (he/him)
-* [thefourtheye](https://github.com/thefourtheye) -
-**Sakthipriyan Vairamani** <thechargingvolcano@gmail.com> (he/him)
* [TimothyGu](https://github.com/TimothyGu) -
**Tiancheng "Timothy" Gu** <timothygu99@gmail.com> (he/him)
* [tniessen](https://github.com/tniessen) -
@@ -540,6 +544,8 @@ For information about the governance of the Node.js project, see
**Stefan Budeanu** <stefan@budeanu.com>
* [tellnes](https://github.com/tellnes) -
**Christian Tellnes** <christian@tellnes.no>
+* [thefourtheye](https://github.com/thefourtheye) -
+**Sakthipriyan Vairamani** <thechargingvolcano@gmail.com> (he/him)
* [thlorenz](https://github.com/thlorenz) -
**Thorsten Lorenz** <thlorenz@gmx.de>
* [trevnorris](https://github.com/trevnorris) -
@@ -571,6 +577,8 @@ Primary GPG keys for Node.js Releasers (some Releasers sign with subkeys):
`8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600`
* **Myles Borins** <myles.borins@gmail.com>
`C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8`
+* **Richard Lau** <riclau@uk.ibm.com>
+`C82FA3AE1CBEDC6BE46B9360C43CEC45C17AB93C`
* **Rod Vagg** <rod@vagg.org>
`DD8F2338BAE7501E3DD5AC78C273792F7D83545D`
* **Ruben Bridgewater** <ruben@bridgewater.de>
@@ -586,6 +594,7 @@ gpg --keyserver pool.sks-keyservers.net --recv-keys 94AE36675C464D64BAFA68DD7434
gpg --keyserver pool.sks-keyservers.net --recv-keys 71DCFD284A79C3B38668286BC97EC7A07EDE3FC1
gpg --keyserver pool.sks-keyservers.net --recv-keys 8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600
gpg --keyserver pool.sks-keyservers.net --recv-keys C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8
+gpg --keyserver pool.sks-keyservers.net --recv-keys C82FA3AE1CBEDC6BE46B9360C43CEC45C17AB93C
gpg --keyserver pool.sks-keyservers.net --recv-keys DD8F2338BAE7501E3DD5AC78C273792F7D83545D
gpg --keyserver pool.sks-keyservers.net --recv-keys A48C2BEE680E841632CD4E44F07496B3EB3C1762
gpg --keyserver pool.sks-keyservers.net --recv-keys B9E2F5981AA6E0CD28160D9FF13993A75599653C
diff --git a/benchmark/async_hooks/promises.js b/benchmark/async_hooks/promises.js
index 5632a6901d611b..9927ec0dc504e9 100644
--- a/benchmark/async_hooks/promises.js
+++ b/benchmark/async_hooks/promises.js
@@ -19,6 +19,11 @@ const tests = {
promiseResolve() {},
destroy() {}
}).enable();
+ },
+ enabledWithInitOnly() {
+ hook = createHook({
+ init() {}
+ }).enable();
}
};
@@ -27,6 +32,7 @@ const bench = common.createBenchmark(main, {
asyncHooks: [
'enabled',
'enabledWithDestroy',
+ 'enabledWithInitOnly',
'disabled',
]
});
diff --git a/benchmark/napi/ref/index.js b/benchmark/napi/ref/index.js
index 3a5e1988275eaa..a8642a54b21990 100644
--- a/benchmark/napi/ref/index.js
+++ b/benchmark/napi/ref/index.js
@@ -10,8 +10,10 @@ function callNewWeak() {
function main({ n }) {
addon.count = 0;
bench.start();
- while (addon.count < n) {
- callNewWeak();
- }
- bench.end(n);
+ new Promise((resolve) => {
+ (function oneIteration() {
+ callNewWeak();
+ setImmediate(() => ((addon.count < n) ? oneIteration() : resolve()));
+ })();
+ }).then(() => bench.end(n));
}
diff --git a/benchmark/worker/messageport.js b/benchmark/worker/messageport.js
index 8e2ddae73ff3ab..2f0d6f0621e8c8 100644
--- a/benchmark/worker/messageport.js
+++ b/benchmark/worker/messageport.js
@@ -4,6 +4,7 @@ const common = require('../common.js');
const { MessageChannel } = require('worker_threads');
const bench = common.createBenchmark(main, {
payload: ['string', 'object'],
+ style: ['eventtarget', 'eventemitter'],
n: [1e6]
});
@@ -25,14 +26,26 @@ function main(conf) {
const { port1, port2 } = new MessageChannel();
let messages = 0;
- port2.onmessage = () => {
+ function listener() {
if (messages++ === n) {
bench.end(n);
port1.close();
} else {
write();
}
- };
+ }
+
+ switch (conf.style) {
+ case 'eventtarget':
+ port2.onmessage = listener;
+ break;
+ case 'eventemitter':
+ port2.on('message', listener);
+ break;
+ default:
+ throw new Error('Unsupported listener type');
+ }
+
bench.start();
write();
diff --git a/deps/npm/AUTHORS b/deps/npm/AUTHORS
index 313dba9e161f89..427166a068bf50 100644
--- a/deps/npm/AUTHORS
+++ b/deps/npm/AUTHORS
@@ -699,3 +699,6 @@ Peter Fich
Maxwell Gerber
Sean Poulter
vanishcode
+Jean-Charles Sisk
+Martin Packman
+Danielle Adams
diff --git a/deps/npm/CHANGELOG.md b/deps/npm/CHANGELOG.md
index 85230c8e185636..f8f356d46cf026 100644
--- a/deps/npm/CHANGELOG.md
+++ b/deps/npm/CHANGELOG.md
@@ -1,3 +1,23 @@
+## 6.14.7 (2020-07-21)
+
+### BUG FIXES
+* [`de5108836`](https://github.com/npm/cli/commit/de5108836189bddf28d4d3542f9bd5869cc5c2e9) [#784](https://github.com/npm/cli/pull/784) npm explore spawn shell correctly ([@jasisk](https://github.com/jasisk))
+* [`36e6c01d3`](https://github.com/npm/cli/commit/36e6c01d334c4db75018bc6a4a0bef726fd41ce4) git tag handling regression on shrinkwrap ([@claudiahdz](https://github.com/claudiahdz))
+* [`1961c9369`](https://github.com/npm/cli/commit/1961c9369c92bf8fe530cecba9834ca3c7f5567c) [#288](https://github.com/npm/cli/pull/288) Fix package id in shrinkwrap lifecycle step output ([@bz2](https://github.com/bz2))
+* [`87888892a`](https://github.com/npm/cli/commit/87888892a1282cc3edae968c3ae4ec279189271c) [#1009](https://github.com/npm/cli/pull/1009) gracefully handle error during npm install ([@danielleadams](https://github.com/danielleadams))
+* [`6fe2bdc25`](https://github.com/npm/cli/commit/6fe2bdc25e7961956e5c0067fa4db54ff1bd0dbd) [#1547](https://github.com/npm/cli/pull/1547) npm ls --parseable --long output ([@ruyadorno](https://github.com/ruyadorno))
+
+### DEPENDENCIES
+* [`2d78481c7`](https://github.com/npm/cli/commit/2d78481c7ec178e628ce23df940f73a05d5c6367) update mkdirp on tacks ([@claudiahdz](https://github.com/claudiahdz))
+* [`4e129d105`](https://github.com/npm/cli/commit/4e129d105eba3b12d474caa6e5ca216a98deb75a) uninstall npm-registry-couchapp ([@claudiahdz](https://github.com/claudiahdz))
+* [`8e1869e27`](https://github.com/npm/cli/commit/8e1869e278d1dd37ddefd6b4e961d1bb17fc9d09) update marked dev dep ([@claudiahdz](https://github.com/claudiahdz))
+* [`6a6151f37`](https://github.com/npm/cli/commit/6a6151f377063c6aca852c859c01910edd235ec6) `libnpx@10.2.4` ([@claudiahdz](https://github.com/claudiahdz))
+* [`dc21422eb`](https://github.com/npm/cli/commit/dc21422eb1ca1a4a19f160fad0e924566e08c496) `bin-links@1.1.8` ([@claudiahdz](https://github.com/claudiahdz))
+* [`d341f88ce`](https://github.com/npm/cli/commit/d341f88ce6feb3df1dcb37f34910fcc6c1db85f2) `gentle-fs@2.3.1` ([@claudiahdz](https://github.com/claudiahdz))
+* [`3e168d49b`](https://github.com/npm/cli/commit/3e168d49b41574809cae2ad013776a00d3f20ff4) `libcipm@4.0.8` ([@claudiahdz](https://github.com/claudiahdz))
+* [`6ae942a51`](https://github.com/npm/cli/commit/6ae942a510520b7dff11b5b78eebeff1706e38af) `npm-audit-report@1.3.3` ([@claudiahdz](https://github.com/claudiahdz))
+* [`6a35e3dee`](https://github.com/npm/cli/commit/6a35e3deec275bf2ae76603acd424a0640458047) `npm-lifecycle@3.1.5` ([@claudiahdz](https://github.com/claudiahdz))
+
## 6.14.6 (2020-07-07)
### BUG FIXES
diff --git a/deps/npm/CONTRIBUTING.md b/deps/npm/CONTRIBUTING.md
index c08bd090cb64b4..3e3512ffeaec05 100644
--- a/deps/npm/CONTRIBUTING.md
+++ b/deps/npm/CONTRIBUTING.md
@@ -123,7 +123,7 @@ We often want to know if the bug we've fixed for the feature we've added has any
1. Make a pull-request against this repository
2. Add the following comment to the pull-request: "`test this please ✅`"
-This will trigger the [benmark suite](https://github.com/npm/benchmarks) to run against your pull-request, and when it's finished running it will post a comment on your pull-request just like bellow. You'll be able to see the results from the suite inline in your pull-request.
+This will trigger the [benchmark suite](https://github.com/npm/benchmarks) to run against your pull-request, and when it's finished running it will post a comment on your pull-request just like below. You'll be able to see the results from the suite inline in your pull-request.
> You'll notice that the bot-user will also add a 🚀 reaction to your comment to
let you know that it's sent the request to start the benchmark suite.
@@ -186,7 +186,6 @@ You'll need a few things installed in order to update and test the CLI project d
> Package vendoring is commonly referred to as the case where dependent packages are stored in the same place as your project. That usually means you dependencies are checked into your source management system, such as Git.
-The CLI project vendors it's dependencies in the `node_modules/` folder. Meaning all the dependencies that the CLI project uses are contained withing the project itself. This is represented by the `bundledDependencies` section in the root level `package.json` file. The main reason for this is because the `npm` CLI project is distributed with the NodeJS runtime and needs to work out of the box, which means all dependencies need to be available after the runtime is installed.
+The CLI project vendors its dependencies in the `node_modules/` folder. Meaning all the dependencies that the CLI project uses are contained within the project itself. This is represented by the `bundledDependencies` section in the root level `package.json` file. The main reason for this is because the `npm` CLI project is distributed with the NodeJS runtime and needs to work out of the box, which means all dependencies need to be available after the runtime is installed.
There are a couple scripts created to help manage this process in the `scripts/` folder.
-
diff --git a/deps/npm/docs/public/cli-commands/npm-access/index.html b/deps/npm/docs/public/cli-commands/npm-access/index.html
index 2088d14aa48344..9ad76a3e9f5e91 100644
--- a/deps/npm/docs/public/cli-commands/npm-access/index.html
+++ b/deps/npm/docs/public/cli-commands/npm-access/index.html
@@ -26,7 +26,7 @@
/* sc-component-id: FoundTypo__Container-sc-1e373sc-0 */
.fMOzaj{margin:80px 0;border-top:1px solid black;padding:20px 0;}
/* sc-component-id: Page__Content-sc-4b62ym-0 */
-.gJQTGP{max-width:760px;margin:auto;padding:0 30px 120px;}