Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

tools: merge stalebot #52642

Closed
wants to merge 2 commits into from
Closed

tools: merge stalebot #52642

wants to merge 2 commits into from

Conversation

avivkeller
Copy link
Member

(Ref: nodejs/admin#860 (comment)

This PR makes the following changes to the stalebot:

  1. Merges the issue stalebot and the pr stalebot into one
  2. Reduce the time from 6 months to 2 months (and the stale->close time from 1 month to 2 weeks)
  3. Uses the latest version of stalebot (not @mhdawson's fork)
  4. Add more links to the message.

Note

This will affect open issues/PRs already, so we should go through those.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 22, 2024
@avivkeller avivkeller added tools Issues and PRs related to the tools directory. and removed tools Issues and PRs related to the tools directory. labels Apr 22, 2024
@targos
Copy link
Member

targos commented Apr 22, 2024

nodejs/admin#860 (comment) suggests to do it in the help repo.

@avivkeller
Copy link
Member Author

I'm aware, I also think it should be applied to both.

@avivkeller
Copy link
Member Author

If we have a PR that we know about, We usually mark it as 'never-stale', or we will be commenting/fixing/implementing it. I think this change will help with closing out the stragglers with no activity.

@bnb
Copy link
Contributor

bnb commented Apr 22, 2024

For reference, 2 months back is the last 10 pages of activity in our Issues tab. There are in total 63 pages currently, meaning 53 pages of issues will be marked as stale and in two weeks with no further updates be closed. The last 5 pages of activity in PRs would be within the allowed window, with 23 pages total meaning that 18 pages of PRs would be closed.

@avivkeller
Copy link
Member Author

Your right. Let's start with the help repo and work from there. Closing here (See the help repo pull)

@avivkeller avivkeller closed this Apr 22, 2024
@avivkeller avivkeller deleted the stalebot branch April 22, 2024 19:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants