src: improve error handling in process_wrap #56977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace ToLocalChecked uses.
nodejs-github-bot
added
c++
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56977 +/- ##
==========================================
- Coverage 89.13% 89.10% -0.04%
==========================================
Files 665 665
Lines 193165 193218 +53
Branches 37191 37208 +17
==========================================
- Hits 172181 172169 -12
- Misses 13729 13754 +25
- Partials 7255 7295 +40
|
anonrig
approved these changes
Feb 9, 2025
| stdios->Get(context, i).ToLocalChecked().As<Object>(); | ||
| Local<Value> type = | ||
| stdio->Get(context, env->type_string()).ToLocalChecked(); | ||
| Local<Value> val; |
There was a problem hiding this comment.
Should we define this variable outside of the loop? Same goes for 143 and 144.
jasnell
added
author ready
legendecas
approved these changes
Feb 11, 2025
nodejs-github-bot
removed
the
commit-queue
|
Landed in 888e5eb |
targos
pushed a commit
that referenced
this pull request
Feb 17, 2025
Replace ToLocalChecked uses. PR-URL: #56977 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
acidiney
pushed a commit
to acidiney/node
that referenced
this pull request
Feb 23, 2025
Replace ToLocalChecked uses. PR-URL: nodejs#56977 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace ToLocalChecked uses.