Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

crypto: fix missing OPENSSL_NO_ENGINE guard #57012

Merged
merged 1 commit into from
Feb 14, 2025
Merged

crypto: fix missing OPENSSL_NO_ENGINE guard #57012

merged 1 commit into from
Feb 14, 2025
+4 −0

Conversation

codebytere
Copy link
Member

Refs #56526.

Fixes compilation failure when OPENSSL_NO_ENGINE is defined:

../../third_party/electron_node/src/crypto/crypto_util.cc:32:16: error: no member named 'EnginePointer' in namespace 'ncrypto'; did you mean 'ECPointPointer'?
   32 | using ncrypto::EnginePointer;
      |       ~~~~~~~~~^~~~~~~~~~~~~
      |                ECPointPointer
../../third_party/electron_node/deps/ncrypto/ncrypto.h:889:7: note: 'ECPointPointer' declared here
  889 | class ECPointPointer final {
      |       ^
1 error generated.

@codebytere codebytere requested a review from jasnell February 12, 2025 12:17
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Feb 12, 2025
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 12, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 12, 2025
@nodejs-github-bot

This comment was marked as outdated.

# to view
@codecov Codecov

This comment was marked as outdated.

# to view
@nodejs-github-bot

This comment was marked as outdated.

# to view
@nodejs-github-bot

This comment was marked as outdated.

# to view
@codebytere codebytere mentioned this pull request Feb 13, 2025
Merged
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 13, 2025 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/65188/ 💚

@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 14, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 14, 2025
@nodejs-github-bot nodejs-github-bot merged commit fc7682c into nodejs:main Feb 14, 2025
61 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in fc7682c

targos pushed a commit that referenced this pull request Feb 17, 2025
@codebytere @targos
crypto: fix missing OPENSSL_NO_ENGINE guard
dfdaa92 
PR-URL: #57012
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
@codebytere @acidiney
crypto: fix missing OPENSSL_NO_ENGINE guard
a56af79 
PR-URL: nodejs#57012
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actions github-actions bot mentioned this pull request Feb 25, 2025
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@codebytere @nodejs-github-bot @jasnell @lpinca @joyeecheung @richardlau