Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

cli: allow --cpu-prof* in NODE_OPTIONS #57018

Merged
merged 1 commit into from
Feb 20, 2025
Merged

cli: allow --cpu-prof* in NODE_OPTIONS #57018

merged 1 commit into from
Feb 20, 2025

Conversation

Ceres6
Copy link
Contributor

@Ceres6 Ceres6 commented Feb 12, 2025

Added --cpu-prof* flags to NODE_OPTIONS envvar and docs

Fixes: #56944

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 12, 2025
@Ceres6
Copy link
Contributor Author

Ceres6 commented Feb 12, 2025

cc @dmichon-msft @joyeecheung @Qard

joyeecheung
joyeecheung approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 12, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 12, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65157/

@codecov Codecov
Copy link

codecov bot commented Feb 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.12%. Comparing base (1671921) to head (e5083e3).
Report is 104 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57018      +/-   ##
==========================================
- Coverage   89.15%   89.12%   -0.04%     
==========================================
  Files         665      665              
  Lines      192798   193193     +395     
  Branches    37130    37223      +93     
==========================================
+ Hits       171886   172177     +291     
- Misses      13673    13757      +84     
- Partials     7239     7259      +20
Files with missing lines Coverage Δ
src/node_options.cc 87.97% <ø> (+0.01%) ⬆️

... and 65 files with indirect coverage changes

Armanidashh
Armanidashh reviewed Feb 13, 2025
View reviewed changes
Copy link

@Armanidashh Armanidashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65183/

@Qard Qard added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 20, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 20, 2025
@nodejs-github-bot nodejs-github-bot merged commit 15fec13 into nodejs:main Feb 20, 2025
66 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 15fec13

acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
@Ceres6 @acidiney
cli: allow --cpu-prof* in NODE_OPTIONS
a0156a4 
Fixes: nodejs#56944
PR-URL: nodejs#57018
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos pushed a commit that referenced this pull request Feb 24, 2025
@Ceres6 @targos
cli: allow --cpu-prof* in NODE_OPTIONS
891a239 
Fixes: #56944
PR-URL: #57018
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actions github-actions bot mentioned this pull request Feb 25, 2025
Merged
targos pushed a commit that referenced this pull request Feb 25, 2025
@Ceres6 @targos
cli: allow --cpu-prof* in NODE_OPTIONS
e26d484 
Fixes: #56944
PR-URL: #57018
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@dmichon-msft
Copy link

Any chance of this getting backported to 22.x?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Armanidashh Armanidashh Armanidashh left review comments

@Qard Qard Qard approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support --cpu-prof in NODE_OPTIONS
7 participants
@Ceres6 @nodejs-github-bot @dmichon-msft @Qard @joyeecheung @legendecas @Armanidashh