From 76f28a8ebc679c9136e06157bea395b93ea1635f Mon Sep 17 00:00:00 2001 From: cdnadmin Date: Thu, 1 Dec 2016 10:56:23 -0600 Subject: [PATCH 1/2] test: change `asset.equal` to `assert.strictEqual` nina 2016 --- test/parallel/test-fs-append-file-sync.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/test/parallel/test-fs-append-file-sync.js b/test/parallel/test-fs-append-file-sync.js index d337e6ff326995..af8366084ce3c2 100644 --- a/test/parallel/test-fs-append-file-sync.js +++ b/test/parallel/test-fs-append-file-sync.js @@ -24,7 +24,7 @@ fs.appendFileSync(filename, data); var fileData = fs.readFileSync(filename); -assert.equal(Buffer.byteLength(data), fileData.length); +assert.strictEqual(Buffer.byteLength(data), fileData.length); // test that appends data to a non empty file var filename2 = join(common.tmpDir, 'append-sync2.txt'); @@ -34,7 +34,7 @@ fs.appendFileSync(filename2, data); var fileData2 = fs.readFileSync(filename2); -assert.equal(Buffer.byteLength(data) + currentFileData.length, +assert.strictEqual(Buffer.byteLength(data) + currentFileData.length, fileData2.length); // test that appendFileSync accepts buffers @@ -46,7 +46,7 @@ fs.appendFileSync(filename3, buf); var fileData3 = fs.readFileSync(filename3); -assert.equal(buf.length + currentFileData.length, fileData3.length); +assert.strictEqual(buf.length + currentFileData.length, fileData3.length); // test that appendFile accepts numbers. var filename4 = join(common.tmpDir, 'append-sync4.txt'); @@ -58,12 +58,12 @@ fs.appendFileSync(filename4, num, { mode: m }); // windows permissions aren't unix if (!common.isWindows) { var st = fs.statSync(filename4); - assert.equal(st.mode & 0o700, m); + assert.strictEqual(st.mode & 0o700, m); } var fileData4 = fs.readFileSync(filename4); -assert.equal(Buffer.byteLength('' + num) + currentFileData.length, +assert.strictEqual(Buffer.byteLength('' + num) + currentFileData.length, fileData4.length); // test that appendFile accepts file descriptors @@ -76,7 +76,7 @@ fs.closeSync(filename5fd); var fileData5 = fs.readFileSync(filename5); -assert.equal(Buffer.byteLength(data) + currentFileData.length, +assert.strictEqual(Buffer.byteLength(data) + currentFileData.length, fileData5.length); //exit logic for cleanup From a66cd9af38f336e9e30825864927cc64950f68ba Mon Sep 17 00:00:00 2001 From: Ian White Date: Fri, 2 Dec 2016 09:53:40 -0600 Subject: [PATCH 2/2] fix code alignment --- test/parallel/test-fs-append-file-sync.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/parallel/test-fs-append-file-sync.js b/test/parallel/test-fs-append-file-sync.js index af8366084ce3c2..4a252f7c89c11a 100644 --- a/test/parallel/test-fs-append-file-sync.js +++ b/test/parallel/test-fs-append-file-sync.js @@ -35,7 +35,7 @@ fs.appendFileSync(filename2, data); var fileData2 = fs.readFileSync(filename2); assert.strictEqual(Buffer.byteLength(data) + currentFileData.length, - fileData2.length); + fileData2.length); // test that appendFileSync accepts buffers var filename3 = join(common.tmpDir, 'append-sync3.txt'); @@ -64,7 +64,7 @@ if (!common.isWindows) { var fileData4 = fs.readFileSync(filename4); assert.strictEqual(Buffer.byteLength('' + num) + currentFileData.length, - fileData4.length); + fileData4.length); // test that appendFile accepts file descriptors var filename5 = join(common.tmpDir, 'append-sync5.txt'); @@ -77,7 +77,7 @@ fs.closeSync(filename5fd); var fileData5 = fs.readFileSync(filename5); assert.strictEqual(Buffer.byteLength(data) + currentFileData.length, - fileData5.length); + fileData5.length); //exit logic for cleanup