Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

styl,hbs: add header dropdown menus #68

Closed
wants to merge 3 commits into from
Closed

Conversation

Fishrock123
Copy link
Contributor

Proof of concept to see if the @nodejs/website folks like it.

I think I can do an even more clever and nicer effects by changing some stuff around.

@Fishrock123 Fishrock123 added content Issues/pr concerning content design labels Aug 31, 2015
@Fishrock123
Copy link
Contributor Author

cc @fhemberger Thoughts?

@fhemberger
Copy link
Contributor

@Fishrock123 Sorry for the late reply, totally forgot about this one.
Rebased against current master. Here are some screenshots for @nodejs/website:

@fhemberger
Copy link
Contributor

I must say I'm not entirely happy yet with this solution. At the moment, the sub-navigation and its items don't align well, making it look a bit odd. Maybe this can be fixed with a bit of CSS tweaking.

@Fishrock123
Copy link
Contributor Author

@nodejs/website If this is something you feel would fit well into the design, I'll put a considerable amount of effort in trying to make it work correctly.

@mikeal
Copy link
Contributor

mikeal commented Oct 15, 2015

I actually don't think this is a great idea. From prior experience i know that the rate at which people click on the "main" page from that top nav drops to near zero if there is a nav below it. I'd like to see those landing pages get a lot of views and to be a good entry point for newcomers. We can't control how people enter some of these more advanced topics if we go this route.

@fhemberger
Copy link
Contributor

I feel similar to what @mikeal said. It also requires quite a bit of CSS fine tuning, which might become an issue as well as soon as we add localizations (different text lengths, RTL languages), so I think the work you have to put into it doesn't match the outcome.

@bnb
Copy link
Contributor

bnb commented Oct 16, 2015

Has this come to a decision?

@Fishrock123
Copy link
Contributor Author

It also requires quite a bit of CSS fine tuning, which might become an issue as well as soon as we add localizations (different text lengths, RTL languages), so I think the work you have to put into it doesn't match the outcome.

I feel quite confident in the ability to make it work quite resizable. :)

That being said I'll agree with @mikeal. Closing.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
content Issues/pr concerning content design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants