Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

use resolve just for resolve-y things, use is-core-module for "is this a core module" things #71

Open
polRk opened this issue May 17, 2023 · 2 comments

Comments

@polRk
Copy link

polRk commented May 17, 2023

browserify/resolve#297
browserify/resolve#302

@trentm
Copy link
Contributor

trentm commented May 22, 2023

Note to self: See the main discussions at open-telemetry/opentelemetry-js#3813 and browserify/resolve#297

@trentm
Copy link
Contributor

trentm commented May 26, 2023

Rather I think the path should be to:

  • Stop using the core-related functionality from resolve (they are going away in resolve@2) and use the equivalents from is-core-module instead. The data file used for the core-related exports are maintained in is-core-module, so that's the best place to get the up-to-date values.
  • Eventually move to using resolve@2 when a non-pre-release version of that is released.

@trentm trentm changed the title remove usage of browserify / resolve use resolve just for resolve-y things, use is-core-module for "is this a core module" things May 26, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants