From d97209a5c95cfe9bdc23f5ca2bae6a7811e13423 Mon Sep 17 00:00:00 2001 From: Tim Fish Date: Thu, 30 Jan 2025 22:54:01 +0100 Subject: [PATCH 1/3] chore: Add governance, CoC and release config --- .github/workflows/release-please.yml | 33 +++++++++++++++++++++++++++ .release-please-manifest.json | 3 +++ CODE_OF_CONDUCT.md | 4 ++++ CONTRIBUTING.md | 34 ++++++++++++++++++++++++++++ GOVERNANCE.md | 28 +++++++++++++++++++++++ release-please-config.json | 10 ++++++++ 6 files changed, 112 insertions(+) create mode 100644 .github/workflows/release-please.yml create mode 100644 .release-please-manifest.json create mode 100644 CODE_OF_CONDUCT.md create mode 100644 CONTRIBUTING.md create mode 100644 GOVERNANCE.md create mode 100644 release-please-config.json diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml new file mode 100644 index 0000000..7df34ab --- /dev/null +++ b/.github/workflows/release-please.yml @@ -0,0 +1,33 @@ +name: release-please + +on: + push: + branches: + - main + +jobs: + release-please: + runs-on: ubuntu-latest + outputs: + release_created: ${{ steps.release.outputs.release_created }} + steps: + - uses: googleapis/release-please-action@v4 + id: release + with: + token: ${{ secrets.RELEASE_PLEASE_GITHUB_TOKEN }} + config-file: release-please-config.json + manifest-file: .release-please-manifest.json + + npm-publish: + needs: release-please + if: ${{ needs.release-please.outputs.release_created }} + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 + with: + node-version: lts/* + registry-url: 'https://registry.npmjs.org' + - run: npm publish --access public + env: + NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} diff --git a/.release-please-manifest.json b/.release-please-manifest.json new file mode 100644 index 0000000..cd52c1e --- /dev/null +++ b/.release-please-manifest.json @@ -0,0 +1,3 @@ +{ + ".": "7.5.0" +} diff --git a/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md new file mode 100644 index 0000000..068a964 --- /dev/null +++ b/CODE_OF_CONDUCT.md @@ -0,0 +1,4 @@ +# Code of Conduct + +The Code of Conduct, which applies to this project, can be found at +https://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 0000000..3aff213 --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,34 @@ +# Contributing to `require-in-the-middle` + +## Code of Conduct + +Please read the +[Code of Conduct](https://github.com/nodejs/admin/blob/main/CODE_OF_CONDUCT.md) +which explains the minimum behavior expectations for `require-in-the-middle` contributors. + + +## Developer's Certificate of Origin 1.1 + +By making a contribution to this project, I certify that: + +* (a) The contribution was created in whole or in part by me and I + have the right to submit it under the open source license + indicated in the file; or + +* (b) The contribution is based upon previous work that, to the best + of my knowledge, is covered under an appropriate open source + license and I have the right under that license to submit that + work with modifications, whether created in whole or in part + by me, under the same open source license (unless I am + permitted to submit under a different license), as indicated + in the file; or + +* (c) The contribution was provided directly to me by some other + person who certified (a), (b) or (c) and I have not modified + it. + +* (d) I understand and agree that this project and the contribution + are public and that a record of the contribution (including all + personal information I submit with it, including my sign-off) is + maintained indefinitely and may be redistributed consistent with + this project or the open source license(s) involved. diff --git a/GOVERNANCE.md b/GOVERNANCE.md new file mode 100644 index 0000000..72ecbcf --- /dev/null +++ b/GOVERNANCE.md @@ -0,0 +1,28 @@ +# `require-in-the-middle` Project Governance + +## Collaborators + +`require-in-the-middle` core collaborators maintain the +[nodejs/require-in-the-middle](https://github.com/nodejs/require-in-the-middle) +GitHub repository. The GitHub team for `require-in-the-middle` core +collaborators is +[@nodejs/require-in-the-middle-maintainers](https://github.com/orgs/nodejs/teams/require-in-the-middle-maintainers). +Collaborators have commit access to the +[nodejs/require-in-the-middle](https://github.com/nodejs/require-in-the-middle) +repository. + +Both collaborators and non-collaborators may propose changes to the +`require-in-the-middle` source code. The mechanism to propose such a change is a +GitHub pull request. Collaborators review and merge (_land_) pull requests. + +## PR Approval + +Two collaborators must approve a pull request before the pull request can land. +Approving a pull request indicates that the collaborator accepts responsibility +for the change. Approval must be from collaborators who are not authors of the +change and at least one approval must be from a collaborator outside the authors +direct team. + +If a collaborator opposes a proposed change, then the change cannot land. Often, +discussions or further changes result in collaborators removing their +opposition. diff --git a/release-please-config.json b/release-please-config.json new file mode 100644 index 0000000..bd2303f --- /dev/null +++ b/release-please-config.json @@ -0,0 +1,10 @@ +{ + "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json", + "bootstrap-sha": "57d2459748492abd55e04a679d8b5752b90dfab4", + "packages": { + ".": { + "pull-request-title-pattern": "chore: release v${version}", + "release-type": "node" + } + } +} From 78b111f9b50ed396a9e398ba791bf1e02e195b1b Mon Sep 17 00:00:00 2001 From: Tim Fish Date: Thu, 30 Jan 2025 23:01:00 +0100 Subject: [PATCH 2/3] Update the start sha --- release-please-config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release-please-config.json b/release-please-config.json index bd2303f..e5df25d 100644 --- a/release-please-config.json +++ b/release-please-config.json @@ -1,6 +1,6 @@ { "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json", - "bootstrap-sha": "57d2459748492abd55e04a679d8b5752b90dfab4", + "bootstrap-sha": "32e20c3db5af30a3a7fd7e3445af9916eebd59dd", "packages": { ".": { "pull-request-title-pattern": "chore: release v${version}", From 1a65802f39e38b282072d9bd756a972195bcb864 Mon Sep 17 00:00:00 2001 From: Tim Fish Date: Mon, 3 Feb 2025 15:51:26 +0100 Subject: [PATCH 3/3] Only CI config --- CODE_OF_CONDUCT.md | 4 ---- CONTRIBUTING.md | 34 ---------------------------------- GOVERNANCE.md | 28 ---------------------------- 3 files changed, 66 deletions(-) delete mode 100644 CODE_OF_CONDUCT.md delete mode 100644 CONTRIBUTING.md delete mode 100644 GOVERNANCE.md diff --git a/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md deleted file mode 100644 index 068a964..0000000 --- a/CODE_OF_CONDUCT.md +++ /dev/null @@ -1,4 +0,0 @@ -# Code of Conduct - -The Code of Conduct, which applies to this project, can be found at -https://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md deleted file mode 100644 index 3aff213..0000000 --- a/CONTRIBUTING.md +++ /dev/null @@ -1,34 +0,0 @@ -# Contributing to `require-in-the-middle` - -## Code of Conduct - -Please read the -[Code of Conduct](https://github.com/nodejs/admin/blob/main/CODE_OF_CONDUCT.md) -which explains the minimum behavior expectations for `require-in-the-middle` contributors. - - -## Developer's Certificate of Origin 1.1 - -By making a contribution to this project, I certify that: - -* (a) The contribution was created in whole or in part by me and I - have the right to submit it under the open source license - indicated in the file; or - -* (b) The contribution is based upon previous work that, to the best - of my knowledge, is covered under an appropriate open source - license and I have the right under that license to submit that - work with modifications, whether created in whole or in part - by me, under the same open source license (unless I am - permitted to submit under a different license), as indicated - in the file; or - -* (c) The contribution was provided directly to me by some other - person who certified (a), (b) or (c) and I have not modified - it. - -* (d) I understand and agree that this project and the contribution - are public and that a record of the contribution (including all - personal information I submit with it, including my sign-off) is - maintained indefinitely and may be redistributed consistent with - this project or the open source license(s) involved. diff --git a/GOVERNANCE.md b/GOVERNANCE.md deleted file mode 100644 index 72ecbcf..0000000 --- a/GOVERNANCE.md +++ /dev/null @@ -1,28 +0,0 @@ -# `require-in-the-middle` Project Governance - -## Collaborators - -`require-in-the-middle` core collaborators maintain the -[nodejs/require-in-the-middle](https://github.com/nodejs/require-in-the-middle) -GitHub repository. The GitHub team for `require-in-the-middle` core -collaborators is -[@nodejs/require-in-the-middle-maintainers](https://github.com/orgs/nodejs/teams/require-in-the-middle-maintainers). -Collaborators have commit access to the -[nodejs/require-in-the-middle](https://github.com/nodejs/require-in-the-middle) -repository. - -Both collaborators and non-collaborators may propose changes to the -`require-in-the-middle` source code. The mechanism to propose such a change is a -GitHub pull request. Collaborators review and merge (_land_) pull requests. - -## PR Approval - -Two collaborators must approve a pull request before the pull request can land. -Approving a pull request indicates that the collaborator accepts responsibility -for the change. Approval must be from collaborators who are not authors of the -change and at least one approval must be from a collaborator outside the authors -direct team. - -If a collaborator opposes a proposed change, then the change cannot land. Often, -discussions or further changes result in collaborators removing their -opposition.