Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Incorrect responsive behaviour when displaying a video #104

Open
Freddixx opened this issue Dec 17, 2014 · 7 comments
Open

Incorrect responsive behaviour when displaying a video #104

Freddixx opened this issue Dec 17, 2014 · 7 comments

Comments

@Freddixx
Copy link

Hi,

I don't know if this is a bug or if I misread the documentation somehow. I've been using featherlight a lot lately but this is a real headscratcher for me:

I'm dynamically adding a video to the lightbox using videojs. And the problem is that featherlight's scaling behaviour is a little odd, unless I add a hidden text (a h1 in this case). This looks strange to me. I prepared a fiddle to illustrate the problem:

http://jsfiddle.net/freddixx/oh313bcv/5/

The lightbox scales nicely if you comment in the line:

//playerContainer.appendChild(p);

I'd appreciate any help. I'm sure this is a simple thing once I know what's wrong here..

@marcandre
Copy link
Collaborator

Not too sure.
Is this what you'd like?

@mrmwiebe
Copy link

Yep, I'm having issues when using data-featherlight='iframe'. The Lightbox opens up and you can see the video in a tiny square in the center of the screen. I would really like it to scale up to fill the screen no matter the size and I've been poking at the code for a while now and can't figure out a good solution.

@flywebguy
Copy link

bump

@mfurlend
Copy link

+1

@robneu
Copy link

robneu commented Apr 20, 2016

This is another duplicate of #188

Or I guess it is a duplicate of this, since it's older. Either way, same issue.

@CSobol
Copy link

CSobol commented Feb 7, 2017

This is still occurring. Youtube videos seem to want to load at 300px wide.

@dbworth
Copy link
Contributor

dbworth commented Mar 31, 2018

I also found that the default size of a video in an iFrame is 300 x 150.
In PR #353 I added some example code to the Readme that shows how to stretch a video to fill the window.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants