-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Bootstrap 3.3.2 - unwanted scrollbars #117
Comments
Hmm, I thought it was more a problem of jQuery 1.8.0+ ? |
I think it is not a jQuery problem, you can verify it by changing jQuery version on jsFiddle, |
I had this problem too. Thanks for your css fix! Saved me some time :) |
Thank you K4T for your fix which works nicely, and it's effectively a bug which shows up with Bootstrap 3.3.x. |
+1 👍 Solved my issue with big images, thanks :) |
Nice, K4T - this fixes for big images, but still - if I use "gallery", because of navigation buttons, there are still vertical scroll for large images. |
Is this issue a sole issue of Bootstrap, or does it affect (i.e. large images) also standalone FL instances? |
The proposed solution does only work with images (and iframes)... Test it on src/index.html with the other options... |
This is not a Bootstrap problem. It's a jQuery problem with versions later than 1.7.2. K4T's css works to a point but it will start to distort the image at smaller sizes. Unfortunately using jQuery migrate doesn't appear to help. |
Adding this to a non bootstap project fixed the scrollbars immediately. |
For me, a fix was .featherlight-inner {
margin-top: 0px;
margin-bottom: 0px;
} to override the following rules of Bootstrap: img {
margin-bottom: 24px;
margin-top: 17px;
} Perhaps the stylesheet of FL should set all padding and margin values. |
Hello, featherlight have problem with the newest Twitter Bootstrap v3.3.2. You can see it here:
http://jsfiddle.net/k5Lwxf1L/1/
Notice additional scrollbars. If you don`t see them than change viewport size and look what will happen.
Solution:
Overwrite CSS with those rules (just paste it into provided fiddle):
Problem is probably caused by box-size reset in current version of Bootstrap. It is a bit different than in older Bootstrap.
Your _onResize method, line: https://github.com/noelboss/featherlight/blob/master/src/featherlight.js#L489
Variable w have always wrong value, cause of wrong value returned by .css('width').
The text was updated successfully, but these errors were encountered: