Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Providing scss files for better modularity #198

Open
andreasisaak opened this issue Jan 21, 2016 · 4 comments
Open

Providing scss files for better modularity #198

andreasisaak opened this issue Jan 21, 2016 · 4 comments

Comments

@andreasisaak
Copy link

Would it be possible that you providing scss files with the package? If desired, i write the pull request :)

@marcandre
Copy link
Collaborator

That could be nice, except it is not trivial to do.

We currently use the src/ files directly when developing & testing. There would have to be a "compiling process". It wouldn't be worth the annoyance just for scss though. But If we are to do this, we could as well move to ES6. I'd like to do that one day (like I did with Parsley). It would be easy to add scss processing to the gulp file.

In short: producing the scss file is easy, but it would have to be after a move to ES6. Adapting the project to ES6 is a bit more involved...

@andreasisaak
Copy link
Author

I think you're right but there are just 3 CSS changes last year. Theoretically, we could first offer SCSS and CSS simultaneously

@Jakobud
Copy link

Jakobud commented Jun 29, 2016

I have a question. Why would converting the CSS to SCSS require converting the JS to ES6 syntax first? It would be super simple to add the SCSS file and then update the gulpfile to add that compiling step in...

EDIT: Just realized this uses Grunt instead of Gulp. Anyways, wouldn't be difficult to add this. Also you should convert over to Gulp ;-)

@marcandre
Copy link
Collaborator

You're right, we could do those in any order. I'd accept a PR for grunt to gulp and/or a PR from css to scss

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants