Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

How to add allowfullscreen to generated vimeo iframe? #247

Closed
mvaneijgen opened this issue Sep 30, 2016 · 3 comments
Closed

How to add allowfullscreen to generated vimeo iframe? #247

mvaneijgen opened this issue Sep 30, 2016 · 3 comments

Comments

@mvaneijgen
Copy link

mvaneijgen commented Sep 30, 2016

I came across this issue where someone was asked to create a new issues, but could not find it.

How do you add webkitallowfullscreen mozallowfullscreen allowfullscreen to the generated vimeo iframe? Must I do it myself with a javascript hack or is there a option in the plugin to add attributes?

@marcandre
Copy link
Collaborator

marcandre commented Sep 30, 2016

The only way right now is via javascript (e.g. in afterContent callback).

There probably should be a better way though, and it probably should be the default.

We should probably create an option iframeTemplate which would contain 'iframe webkitallowfullscreen mozallowfullscreen allowfullscreen' by default.

Do you feel like writing a PR? Only "difficulty" is to not also generate template: ... in the CSS of that iframe. Maybe a regex argument to structure would be the easiest way for that

@nguyenj
Copy link
Contributor

nguyenj commented Dec 12, 2016

@mvaneijgen I have PR that should address this issue. Let me know if it works for you.

@marcandre
Copy link
Collaborator

Fixed & released

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants