Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

iframe - 100% width+height #301

Closed
futureweb opened this issue May 2, 2017 · 2 comments
Closed

iframe - 100% width+height #301

futureweb opened this issue May 2, 2017 · 2 comments

Comments

@futureweb
Copy link

Hello,
is it somehow possible to open featherlight iFrame with 100% width+height?
No luck with this so far ... Hope someone here can help me?! ;-)
thx
Andreas

@marcandre
Copy link
Collaborator

Hi!

My name is Marc-André and I'd like your help. I'm not the original author but I liked the project so much I started contributing more and more; now I'm the (only) maintainer.

How you can help

I'd like you to help me in keeping the issues of this project organized. In particular, I'd very much like questions to be asked on Stack Overflow(reasons just down below) and I think you could help.

To serve that goal, I wrote that questions should be asked on Stack Overflow in the READ ME file. Still, some people asked questions here.

I requested the same in the Contributing Guidelines. Even though GitHub has a paragraph saying "Please review the guidelines for contributing to this repository." that shows up whenever someone creates an issue, some people still asked questions here.

Finally, GitHub allowed us to write a template issue, in which I wrote

This issue tracker is not the place for questions. If you want to ask how to do
something, or to understand why something isn't working the way you expect it to, use
http://stackoverflow.com/questions/ask .
Provide working code, starting from http://jsfiddle.net/JNsu6/15/.
We monitor the tag featherlight.js.

Still, some people like you delete this text and ask a question here. So my question is: why did you feel it was the right thing to do? What could I possibly have done so that this basic wish was respected? I must admit that I feel disrespected whenever someone completely ignores my requests. I understand that most developpers don't feel the urge to help by digging in, inspecting the code and contributing back with great bug reports or pull requests, but it saddens me when people show little care and disregard maintainer wishes.

It would help me a lot if you helped me find a solution so that questions are asked on Stack Overflow.

Why StackOverflow?

I feel that StackOverflow is much better organized for questions and answers than GitHub. Not too surprising, that's exactly what it was designed for!

It has a much better interface to find similar questions, so there's a better chance a question and its answers will help someone else.

I monitor the tag for this project, so I normally will read the question. Sometimes, someone else has already answered the question, which is awesome for whoever wrote the question and for me! That never happens with GitHub issues, btw.

Otherwise I can answer it, especially if it shows what the requester has tried, and has a working example. If something is not clear, there's the comment section, that insure that the discussion doesn't have to be re-read by others that only want the answer.

If the question is badly asked, for example if it has no working example, I can also ignore it and downvote it. Maybe someone will answer it, either way, I don't have an opened issue being stale in GitHub forever.

Indeed, I try as best as I can to keep the list of open GitHub issues down to a minimum. Things there should mostly be things that need to be fixed one way or another. Having a bunch of half baked questions in there would not help at all.

I'm hoping you will reply with good hints on how to achieve this goal. Thanks.

@karfau
Copy link

karfau commented May 31, 2017

I tried to find such question at stackoverflow and tried to find the answer to this question anywhere I could think of. But couldn't find anything helpfull.

I finally came up with a (pure CSS) solution by inspecting the DOM created by featherlight.

Would that be something we or you could put into the wiki?
How would it be possible for me to contribute to your wiki? (Maybe cloning it and providing a patch for you to apply?)
I could create a fiddle that shows what I did...?

(Not sure if the README would be a good place for such details?)

@futureweb If you are willing to repost your question on stackoverflow, I'm happy to answer there as well.

Best Christian

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants