Reserved words validation fails even if other valid slug candidates exist.

[reichertm]

friendly_id 5.0.2, rails 4.1.0.rc1, ruby 2.1.0

A validation error 'Friendly is reserved' is being thrown if the first slug candidate happens to be a reserved word, even if the next slug candidate is valid. Perhaps all the slug candidates should be tried before the 'reserved' error is thrown.

e.g.
Model 'User' with fields 'name' and 'location' has the following slug definition:

friendly_id :slug_candidates, use: [:slugged, :history]
def slug_candidates
   [:name, [:name, :location]]
end

The reserved words contains 'new'

When you try to create a user with name 'new' and location 'ny' the error gets thrown. Perhaps validation should pass creating slug 'new-ny' or such.

[evandrodp]

+1

[gottfrois]

+1

[xymbol]

We're looking at this issue, in the context of other changes and improvements. Please keep subscribed to this issue if you're interested in updates.

[mszyndel]

I would love to provide a patch for that, it is ok @xymbol @reichertm @norman or are you already working on this?

[xymbol]

@hajder Please, feel free to do so. Even if something didn't play well with other changes, we can either get the patch fixed, reuse parts of it or, at least, add a note with the credits. And yes, we've been working on this. Thanks!

[mszyndel]

Ok, so I know how to fix that problem on the conceptual level but not sure about the code. Maybe someone can help out with that? (@xymbol @norman)

In FriendlyId::Reserved a validation is added for slugged model which causes current problem.
My solution would be to override FriendlyId::Candidates#wanted? (which is a private method) to check if slug candidate is on reserved words list (and return false if it is). I don't really know however how to change this method from the FriendlyId::Reserved module.

[norman]

This is now implemented in 23117f7.