Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Panic runtime error when typing command beginning by whitespace #26

Closed
Quentinchampenois opened this issue Dec 5, 2020 · 5 comments
Closed

Comments

@Quentinchampenois
Copy link

Hi, first of all thanks for your work, I am still trying to understand how to connect but it is interesting

Bug description

I have noticed by mistake that when user type a whitespace before the command, the program panic because of invalid memory address or nil pointer dereference.
I can reproduce this bug several times, I think the bug is related to the scroll.

How to reproduce

  • Execute program
  • Enter : /help, beginning with whitespace
  • Then scroll up
  • See error

Environment

  • WhatsCLI v1.0.5 ( based on master branch)
  • MacOS Catalina : v 10.15.6

Stacktrace

I apologize I did not found a log file for the complete error, I just have a screenshot ..

Screenshot 2020-12-05 at 13 09 44

Additional context

I remain available if you need more information.

@normen
Copy link
Owner

normen commented Dec 5, 2020

Right, thats very possible.

@normen
Copy link
Owner

normen commented Dec 5, 2020

I guess this is when you have no chat selected and you are offline?

@normen normen closed this as completed in 49718ac Dec 5, 2020
@Quentinchampenois
Copy link
Author

Yes you are right, I have no chat and seems to be offline (following the screenshot in description)
Sorry for the answer delay !

@normen
Copy link
Owner

normen commented Dec 8, 2020

Okay, does the latest version 1.0.5 fix that? It should. And to connect you need to scan the QR code with your WhatsApp on your phone - I added some documentation to the README

@Quentinchampenois
Copy link
Author

Yes it is fixed,
I have also seen the documentation, thank you !

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants