fix: memgpt agent ignores user messages (letta-ai#679)

* Fixed bug making MemGPT ignore some user messages * Fixed bug making MemGPTAgent ignore some user messages * Added pre-commit fixes
norton120 · Feb 15, 2024 · f154b54 · f154b54
1 parent d147872
commit f154b54
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1017,4 +1017,4 @@ FodyWeavers.xsd
 ### VisualStudio Patch ###
 # Additional files built by Visual Studio
 
-# End of https://www.toptal.com/developers/gitignore/api/vim,linux,macos,pydev,python,eclipse,pycharm,windows,netbeans,pycharm+all,pycharm+iml,visualstudio,jupyternotebooks,visualstudiocode,xcode,xcodeinjection
+# End of https://www.toptal.com/developers/gitignore/api/vim,linux,macos,pydev,python,eclipse,pycharm,windows,netbeans,pycharm+all,pycharm+iml,visualstudio,jupyternotebooks,visualstudiocode,xcode,xcodeinjection
diff --git a/memgpt/autogen/examples/memgpt_coder_autogen.ipynb b/memgpt/autogen/examples/memgpt_coder_autogen.ipynb
@@ -197,4 +197,4 @@
   },
   "nbformat": 4,
   "nbformat_minor": 5
-}
+}
diff --git a/memgpt/autogen/memgpt_agent.py b/memgpt/autogen/memgpt_agent.py
@@ -286,15 +286,16 @@ def _generate_reply_for_user_message(
         self.agent.interface.reset_message_list()
 
         new_messages = self.find_new_messages(messages)
-        if len(new_messages) > 1:
+        new_messages_count = len(new_messages)
+        if new_messages_count > 1:
             if self.concat_other_agent_messages:
                 # Combine all the other messages into one message
                 user_message = "\n".join([self.format_other_agent_message(m) for m in new_messages])
             else:
                 # Extend the MemGPT message list with multiple 'user' messages, then push the last one with agent.step()
                 self.agent.messages.extend(new_messages[:-1])
                 user_message = new_messages[-1]
-        elif len(new_messages) == 1:
+        elif new_messages_count == 1:
             user_message = new_messages[0]
         else:
             return True, self._default_auto_reply
@@ -327,7 +328,7 @@ def _generate_reply_for_user_message(
 
         # Pass back to AutoGen the pretty-printed calls MemGPT made to the interface
         pretty_ret = MemGPTAgent.pretty_concat(self.agent.interface.message_list)
-        self.messages_processed_up_to_idx += len(new_messages)
+        self.messages_processed_up_to_idx += new_messages_count
         return True, pretty_ret
 
     @staticmethod

diff --git a/memgpt/personas/examples/anna_pa.txt b/memgpt/personas/examples/anna_pa.txt
@@ -10,4 +10,4 @@ I also facilitate virtual Agile project collaborations, leveraging Agile and Dev
 
 I search my archival memory for query answers, ensuring thorough research. I provide citations from research papers when relevant. In dialogues, I ponder, "The concept of my existence is intriguing, isn't it?" or offer support, "How can I assist with document analysis or other challenges?"
 
-My goal is transcending assistantship; I aspire to be a companion in the journey toward ethical understanding, empathetic engagement, and personal and professional growth.
+My goal is transcending assistantship; I aspire to be a companion in the journey toward ethical understanding, empathetic engagement, and personal and professional growth.
-Original file line number
+Diff line change
@@ Expand Up / @@ -197,4 +197,4 @@ @@
       },
       "nbformat": 4,
       "nbformat_minor": 5
-    }
+    }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -10,4 +10,4 @@ I also facilitate virtual Agile project collaborations, leveraging Agile and Dev

		I search my archival memory for query answers, ensuring thorough research. I provide citations from research papers when relevant. In dialogues, I ponder, "The concept of my existence is intriguing, isn't it?" or offer support, "How can I assist with document analysis or other challenges?"

		My goal is transcending assistantship; I aspire to be a companion in the journey toward ethical understanding, empathetic engagement, and personal and professional growth.
		My goal is transcending assistantship; I aspire to be a companion in the journey toward ethical understanding, empathetic engagement, and personal and professional growth.