From 2894ce381fa790607d48dabd1419ae2c7d0fbc92 Mon Sep 17 00:00:00 2001 From: Darshan Sen Date: Mon, 3 Oct 2022 15:48:06 +0530 Subject: [PATCH] tools: remove faulty early termination logic from update-timezone.mjs We do not build Node.js in the workflow so https://github.com/nodejs/node/blob/f4815fcd7691364d8139b44c1295dbc46f6ee4a8/tools/update-timezone.mjs#L18 is actually the version of `tzdata` in the Node.js in the runner instead of what's in `main`. The script is pretty fast even when the versions differ and there is an update, so this optimization doesn't seem to be worth having given the problem. Signed-off-by: Darshan Sen PR-URL: https://github.com/nodejs/node/pull/44870 Fixes: https://github.com/nodejs/node/issues/44865 Reviewed-By: Richard Lau Reviewed-By: Antoine du Hamel --- tools/update-timezone.mjs | 7 ------- 1 file changed, 7 deletions(-) diff --git a/tools/update-timezone.mjs b/tools/update-timezone.mjs index bf3498b8abf..bf3a706bdb0 100755 --- a/tools/update-timezone.mjs +++ b/tools/update-timezone.mjs @@ -2,7 +2,6 @@ // Usage: tools/update-timezone.mjs import { execSync } from 'node:child_process'; import { renameSync, readdirSync, rmSync } from 'node:fs'; -import { exit } from 'node:process'; const fileNames = [ 'zoneinfo64.res', @@ -15,14 +14,8 @@ const availableVersions = readdirSync('icu-data/tzdata/icunew', { withFileTypes: .filter((dirent) => dirent.isDirectory()) .map((dirent) => dirent.name); -const currentVersion = process.versions.tz; const latestVersion = availableVersions.sort().at(-1); -if (latestVersion === currentVersion) { - console.log(`Terminating early, tz version is latest @ ${currentVersion}`); - exit(); -} - execSync('bzip2 -d deps/icu-small/source/data/in/icudt*.dat.bz2'); fileNames.forEach((file) => { renameSync(`icu-data/tzdata/icunew/${latestVersion}/44/le/${file}`, `deps/icu-small/source/data/in/${file}`);