Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

vote: tag 1.0.0 #157

Closed
5 of 6 tasks
Tracked by #749
shizhMSFT opened this issue Jul 21, 2023 · 5 comments
Closed
5 of 6 tasks
Tracked by #749

vote: tag 1.0.0 #157

shizhMSFT opened this issue Jul 21, 2023 · 5 comments
Assignees
@gokarnm @rgnote @priteshbandi @JeyJeyGao @Two-Hearts
Milestone
1.0.0

Comments

@shizhMSFT
Copy link
Contributor

shizhMSFT commented Jul 21, 2023 •
edited by gokarnm
Loading

Release

This would mean tagging 0c1ec3b as v1.0.0 to release.

Vote

We need at least 4 approvals from 6 maintainers to release notation-core-go v1.0.0.

Changes

The code changes compared to v1.0.0-rc.4 include:

Full Changelog: v1.0.0-rc.4...0c1ec3b

Action Requested

Please respond LGTM or REJECT (with reasoning).
@shizhMSFT shizhMSFT added this to the 1.0.0 milestone Jul 21, 2023
This was referenced Jul 21, 2023
Closed
Closed
@shizhMSFT shizhMSFT changed the title draft: vote: tag 1.0.0 vote: tag 1.0.0 Jul 21, 2023
@Two-Hearts
Copy link
Contributor

LGTM

3 similar comments
@JeyJeyGao
Copy link
Contributor

LGTM

@priteshbandi
Copy link
Contributor

LGTM

@gokarnm
Copy link

gokarnm commented Jul 21, 2023

LGTM

@shizhMSFT
Copy link
Contributor Author

Released v1.0.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@gokarnm gokarnm

@rgnote rgnote

@priteshbandi priteshbandi

@JeyJeyGao JeyJeyGao

@Two-Hearts Two-Hearts

Labels
None yet
Projects
Notary Project Planning Board
Status: Done
Milestone
1.0.0
Development

No branches or pull requests
6 participants
@gokarnm @rgnote @priteshbandi @shizhMSFT @JeyJeyGao @Two-Hearts