Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

vote: tag 1.0.1 #168

Closed
4 of 6 tasks
shizhMSFT opened this issue Oct 19, 2023 · 10 comments
Closed
4 of 6 tasks

vote: tag 1.0.1 #168

shizhMSFT opened this issue Oct 19, 2023 · 10 comments
Assignees

Comments

@shizhMSFT
Copy link
Contributor

shizhMSFT commented Oct 19, 2023

Release

This would mean tagging c834adc as v1.0.1 to release.

Vote

We need at least 4 approvals from 6 maintainers to release notation-core-go v1.0.1.

Changes

The code changes compared to v1.0.0 include:

Full Changelog: v1.0.0...c834adc

Action Requested

Please respond LGTM or REJECT (with reasoning).

@shizhMSFT shizhMSFT added the enhancement New feature or request label Oct 19, 2023
@shizhMSFT shizhMSFT changed the title vote: tag 1.0.0 vote: tag 1.0.1 Oct 19, 2023
@shizhMSFT shizhMSFT assigned shizhMSFT and unassigned shizhMSFT Oct 19, 2023
@shizhMSFT shizhMSFT removed the enhancement New feature or request label Oct 19, 2023
@Two-Hearts
Copy link
Contributor

LGTM

1 similar comment
@JeyJeyGao
Copy link
Contributor

LGTM

@yizha1
Copy link
Contributor

yizha1 commented Oct 19, 2023

I strongly suggest including the fix of this issue #164. Users reported this when they configured the wrong key usage, the error message was a bit misleading. But if we cannot meet the target date of the overall Notation 1.0.1 release plan, this issue will not block.

@shizhMSFT
Copy link
Contributor Author

If #164 can be resolved in time, we can restart the voting process.

@JeyJeyGao
Copy link
Contributor

LGTM

@shizhMSFT
Copy link
Contributor Author

I've updated description to c834adc so that #169 is included. Thus, the voting process is reset.

@Two-Hearts
Copy link
Contributor

LGTM

2 similar comments
@JeyJeyGao
Copy link
Contributor

LGTM

@priteshbandi
Copy link
Contributor

LGTM

@shizhMSFT
Copy link
Contributor Author

Closing as v1.0.1 has been released.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

7 participants