Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

🎁 implement Valkyrie equivalent validations for model resources #102

Closed
5 tasks
Tracked by #86
ShanaLMoore opened this issue Jan 9, 2024 · 1 comment
Closed
5 tasks
Tracked by #86
Labels

Comments

@ShanaLMoore
Copy link

ShanaLMoore commented Jan 9, 2024

the resource models are not active model records anyone, therefore we can't use active model validations.

ref:

Acceptance Criteria

  • if a Generic Work requires a title, the GenericWorkResource should too

Testing Instructions

  • Create a Generic Work. Try to save it without entering a title. The work should not persist and throw an error.
    • Enter a title and save. A work should persist.
  • Create a Generic Work Resource. Try to save it without entering a title. The work should not persist and throw an error.
    • Enter a title and save. A work should persist.
@ShanaLMoore ShanaLMoore changed the title implement Valkyrie equivalent validations for model resources 🎁 implement Valkyrie equivalent validations for model resources Jan 9, 2024
@laritakr laritakr assigned laritakr and unassigned laritakr Jan 25, 2024
@ShanaLMoore
Copy link
Author

I believe this ticket can be closed.

  1. Bulkrax doesn't check for the model's validation.
  2. When we see errors like "missing title" it's coming from a bulkrax config instead.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants