Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

NET6_0 constants not properly defined #279

Open
jeremyVignelles opened this issue Dec 9, 2021 · 3 comments
Open

NET6_0 constants not properly defined #279

jeremyVignelles opened this issue Dec 9, 2021 · 3 comments
Assignees
Labels

Comments

@jeremyVignelles
Copy link

Context

For LibVLCSharp, we need to support Xamarin.Forms projects and old .net versions as well as the new .net6.0 tfms

The issue

A repro can be found here : https://github.com/jeremyVignelles/repro-tfm-msbuild-sdk-extras

It seems that NET6_0_OR_GREATER is not defined anywhere and NET6_0 is only defined in net6.0 and not net6.0-windows

It also seem that I can't use the new top-level statements in such projects.

@clairernovotny clairernovotny self-assigned this Dec 9, 2021
@clairernovotny
Copy link
Collaborator

I noticed this earlier this week as well.

@dsplaisted Before I hunt this down, do you recall where these are defined or what controls them being defined?

@clairernovotny
Copy link
Collaborator

As a workaround, you should be able to set the DisableImplicitFrameworkDefines property to false. For some reason, the extras is setting that to true here:

https://github.com/novotnyllc/MSBuildSdkExtras/blob/main/Source/MSBuild.Sdk.Extras/Build/Platforms.targets#L45

I'm not sure exactly why anymore and I'll need to look closer to see what the side-effects are for all of the other project types.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants