Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: redact all private keys from config output #4142

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

lukekarrys
Copy link
Contributor

No description provided.

@lukekarrys lukekarrys requested a review from a team as a code owner December 8, 2021 22:40
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing regexes one line at a time

@npm-robot
Copy link
Contributor

npm-robot commented Dec 8, 2021

found 1 benchmarks with statistically significant performance regressions

  • app-medium: no-clean
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 49.331 ±2.42 34.551 ±0.41 27.150 ±8.28 24.943 ±1.24 3.365 ±0.03 3.687 ±0.18 2.818 ±0.03 14.236 ±0.20 2.734 ±0.07 3.607 ±0.05
#4142 46.583 ±0.13 31.721 ±0.07 26.419 ±7.79 26.451 ±3.68 3.466 ±0.05 3.665 ±0.24 2.915 ±0.17 14.028 ±0.07 2.623 ±0.07 3.388 ±0.14
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 36.007 ±0.62 25.495 ±0.31 14.910 ±0.35 15.501 ±0.83 3.066 ±0.13 3.013 ±0.10 2.870 ±0.14 10.340 ±0.45 2.443 ±0.01 2.993 ±0.04
#4142 36.387 ±0.72 25.948 ±0.00 15.435 ±0.03 16.978 ±0.50 3.091 ±0.09 3.073 ±0.06 2.873 ±0.13 11.140 ±0.39 2.741 ±0.02 3.265 ±0.05

@nlf nlf force-pushed the lk/redact-password branch from a02ede5 to e605b12 Compare December 8, 2021 23:28
@nlf nlf merged commit e605b12 into release-next Dec 8, 2021
@nlf nlf deleted the lk/redact-password branch December 8, 2021 23:28
@nlf nlf mentioned this pull request Dec 9, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants