-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
npm hook ls
duplicates hook name prefixes
#4201
Comments
@Dionysusnu can i work on this issue? if yes any extra guidance you would like to provide |
It appears that the hooks feature has been disabled on the server side anyways, so I wouldn't waste time on a low priority thing like this. |
If this has been disabled on the server-side, can't we close the issue? |
@Bruce-Hopkins it could still be used by private registries. |
To clarify, the hooks can still get created, modified, and all that around it, so the bug still exists. However, in my testing, the actual hook configured URL was never accessed when the hook should have triggered. That's what I meant by "seemingly disabled on the server side". |
Since this issue is tagged as 'good first issue' and since people looking for 'good first issues' are looking for good first issues that can be assigned now, maybe it would be appropriate to remove the tag. |
@552020 it still is one. The above comments are just folks who don’t think it’s worth the effort, but nobody from npm has agreed with that. |
Hooks for scopes get a double prefix, ie
@@scope
, when shown with thenpm hook ls
command. This is due to the response from the web request already including the prefix in thename
field, and the following lines of code then locally adding the prefix again, duplicating it.The text was updated successfully, but these errors were encountered: