Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

npm hook ls duplicates hook name prefixes #4201

Closed
Dionysusnu opened this issue Dec 30, 2021 · 7 comments · Fixed by #5295
Closed

npm hook ls duplicates hook name prefixes #4201

Dionysusnu opened this issue Dec 30, 2021 · 7 comments · Fixed by #5295
Labels
Bug thing that needs fixing Good First Issue good issue or PR for newcomers Release 8.x work is associated with a specific npm 8 release

Comments

@Dionysusnu
Copy link

Hooks for scopes get a double prefix, ie @@scope, when shown with the npm hook ls command. This is due to the response from the web request already including the prefix in the name field, and the following lines of code then locally adding the prefix again, duplicating it.

@darcyclarke darcyclarke added Bug thing that needs fixing Release 8.x work is associated with a specific npm 8 release Good First Issue good issue or PR for newcomers labels Jan 11, 2022
@ashutoshdhande
Copy link

@Dionysusnu can i work on this issue? if yes any extra guidance you would like to provide

@Dionysusnu
Copy link
Author

It appears that the hooks feature has been disabled on the server side anyways, so I wouldn't waste time on a low priority thing like this.

@Bruce-Hopkins
Copy link

If this has been disabled on the server-side, can't we close the issue?

@ljharb
Copy link
Contributor

ljharb commented Mar 28, 2022

@Bruce-Hopkins it could still be used by private registries.

@Dionysusnu
Copy link
Author

If this has been disabled on the server-side, can't we close the issue?

To clarify, the hooks can still get created, modified, and all that around it, so the bug still exists.

However, in my testing, the actual hook configured URL was never accessed when the hook should have triggered. That's what I meant by "seemingly disabled on the server side".

@552020
Copy link

552020 commented May 30, 2022

Since this issue is tagged as 'good first issue' and since people looking for 'good first issues' are looking for good first issues that can be assigned now, maybe it would be appropriate to remove the tag.

@ljharb
Copy link
Contributor

ljharb commented May 30, 2022

@552020 it still is one. The above comments are just folks who don’t think it’s worth the effort, but nobody from npm has agreed with that.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Bug thing that needs fixing Good First Issue good issue or PR for newcomers Release 8.x work is associated with a specific npm 8 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants